Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix arbitrary command execution via unvalidated bitcoin-cli path#34

Open
bitcoiner-dev wants to merge 1 commit into
masterfrom
sentinel-fix-arbitrary-command-execution-14179680337620087440
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix arbitrary command execution via unvalidated bitcoin-cli path#34
bitcoiner-dev wants to merge 1 commit into
masterfrom
sentinel-fix-arbitrary-command-execution-14179680337620087440

Conversation

@bitcoiner-dev
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The bitcoin_cli parameter sourced from the user profile json was used directly as the target executable in std::process::Command::new(). While immune to bash shell injections like bitcoin-cli ; rm -rf /, it still allowed an attacker with file write access to the config to specify any system binary as the bitcoin_cli executable (e.g., /bin/sh, /usr/bin/python, or C:\Windows\System32\cmd.exe), which would then be executed with attacker-controlled arguments via the bitcoin_cli_args array.
🎯 Impact: Local arbitrary command execution.
πŸ”§ Fix: Implemented validate_bitcoin_cli_path to strictly enforce that the provided path must:

  1. Not contain directory traversal (..)
  2. Be exactly bitcoin-cli or bitcoin-cli.exe
  3. OR be an absolute path where the final executable name is exactly bitcoin-cli or bitcoin-cli.exe.
    βœ… Verification: cargo test --bin zinc-cli verifies the new path enforcement checks.

PR created automatically by Jules for task 14179680337620087440 started by @bitcoiner-dev

Adds explicit allowlist and structural validation to the user-provided
`bitcoin_cli` configuration value prior to spawning a new shell process.

Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant