Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal in snapshot commands#37

Open
bitcoiner-dev wants to merge 1 commit into
masterfrom
sentinel-path-traversal-fix-12334089060266422385
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal in snapshot commands#37
bitcoiner-dev wants to merge 1 commit into
masterfrom
sentinel-path-traversal-fix-12334089060266422385

Conversation

@bitcoiner-dev
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Path traversal vulnerability in src/commands/snapshot.rs. The SnapshotAction::Save and SnapshotAction::Restore commands allowed user-controlled name parameters to be passed directly to Path::join without validation. If an attacker specified an absolute path (e.g., /etc/passwd) or a relative traversal path (e.g., ../../../etc/passwd), Path::join would interpret it and write or read files outside the intended snapshot directory.
🎯 Impact: An attacker could read arbitrary local files by passing an absolute path to snapshot restore, effectively overwriting their profile with file contents, or overwrite arbitrary files by using snapshot save.
πŸ”§ Fix: Implemented strict allowlist validation (crate::utils::validate_file_name) that ensures the snapshot name contains only alphanumeric characters, underscores, and dashes. This is called before path resolution in both snapshot actions.
βœ… Verification: Verified using cargo test and cargo check. Evaluated the edge-case behavior of Path::join via a scratchpad test to ensure the path parsing works safely with the validation in place.


PR created automatically by Jules for task 12334089060266422385 started by @bitcoiner-dev

Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant