π‘οΈ Sentinel: [HIGH] Fix path traversal in snapshot names#44
π‘οΈ Sentinel: [HIGH] Fix path traversal in snapshot names#44bitcoiner-dev wants to merge 1 commit into
Conversation
Adds strict validation to snapshot names to prevent path traversal when saving or restoring snapshots, rejecting names containing '.' or '/'. Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: The CLI snapshot feature used an unvalidated, user-provided string for the snapshot
nameto construct the file path usingsnap_dir.join(format!("{name}.json")). This allows an attacker to inject../sequences into the snapshot name to escape the snapshot directory and read or write arbitrary JSON files with the user's permissions.π― Impact: Path Traversal could lead to unauthorized local privilege escalation, overwriting critical data (like the active profile), or accessing files outside the snapshot directory.
π§ Fix: Introduced
crate::utils::validate_file_nameto strictly validate that the user-provided snapshot name only contains alphanumeric characters, underscores, and dashes. The function is called before doing any disk operations forsaveandrestoreactions.β Verification: Run
cargo test --bin zinc-clito verify no regressions. Code review assessed the validation as robust and complete.Also appended a security learning to
.jules/sentinel.mdas per Sentinel's journal process.PR created automatically by Jules for task 8522664903168902430 started by @bitcoiner-dev