π‘οΈ Sentinel: [CRITICAL] Fix path traversal in profile paths#47
π‘οΈ Sentinel: [CRITICAL] Fix path traversal in profile paths#47bitcoiner-dev wants to merge 1 commit into
Conversation
Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability:
config.profilewas being used unvalidated inPath::joinwhen constructing profile paths and snapshot directories. Ifconfig.profilecontained string values like../or/absolute/path,Path::joinwould traverse the filesystem resulting in arbitrary file creation or manipulation underprofiles/andsnapshots/.π― Impact: This allows malicious profile strings to write data outside the designated directory structure, leading to potential data corruption or arbitrary file writes.
π§ Fix: Added
validate_file_nameinsrc/utils.rswhich implements a strict allowlist matching for alphanumeric characters, dashes, and underscores. Applied this validation insidesrc/paths.rsduring path generation so any traversal character causes a safe exit viaAppError::Invalid.β Verification: Ensure the updated
cargo test --bin zinc-clipasses completely and explicitly checks the new test blocks rejecting paths like../invalidor/etc/passwd.PR created automatically by Jules for task 10536558652879364844 started by @bitcoiner-dev