Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal in profile paths#47

Open
bitcoiner-dev wants to merge 1 commit into
masterfrom
fix-profile-path-traversal-10536558652879364844
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal in profile paths#47
bitcoiner-dev wants to merge 1 commit into
masterfrom
fix-profile-path-traversal-10536558652879364844

Conversation

@bitcoiner-dev
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: config.profile was being used unvalidated in Path::join when constructing profile paths and snapshot directories. If config.profile contained string values like ../ or /absolute/path, Path::join would traverse the filesystem resulting in arbitrary file creation or manipulation under profiles/ and snapshots/.
🎯 Impact: This allows malicious profile strings to write data outside the designated directory structure, leading to potential data corruption or arbitrary file writes.
πŸ”§ Fix: Added validate_file_name in src/utils.rs which implements a strict allowlist matching for alphanumeric characters, dashes, and underscores. Applied this validation inside src/paths.rs during path generation so any traversal character causes a safe exit via AppError::Invalid.
βœ… Verification: Ensure the updated cargo test --bin zinc-cli passes completely and explicitly checks the new test blocks rejecting paths like ../invalid or /etc/passwd.


PR created automatically by Jules for task 10536558652879364844 started by @bitcoiner-dev

Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant