Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix path traversal vulnerability in snapshot names#48

Open
bitcoiner-dev wants to merge 1 commit into
masterfrom
sentinel-fix-path-traversal-6644483708482754008
Open

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix path traversal vulnerability in snapshot names#48
bitcoiner-dev wants to merge 1 commit into
masterfrom
sentinel-fix-path-traversal-6644483708482754008

Conversation

@bitcoiner-dev
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The snapshot save and snapshot restore commands accepted unvalidated user input for the snapshot name, which was directly passed to Path::join(). This allowed a path traversal attack (e.g., ../etc/passwd) to read or overwrite arbitrary files on the user's system under the context of the running application.
🎯 Impact: An attacker could overwrite critical system files or expose sensitive data by providing malicious path traversals as snapshot names.
πŸ”§ Fix: Implemented an explicit allowlist validation crate::utils::validate_file_name that restricts input to alphanumeric characters, dashes, and underscores. This validation is now enforced for all snapshot names prior to joining with the snapshot directory path.
βœ… Verification: cargo test confirms the path validation rejects any input containing . or /, ensuring safe path execution.


PR created automatically by Jules for task 6644483708482754008 started by @bitcoiner-dev

Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant