π‘οΈ Sentinel: [CRITICAL/HIGH] Fix path traversal vulnerability in snapshot names#48
Conversation
Co-authored-by: bitcoiner-dev <75873427+bitcoiner-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The
snapshot saveandsnapshot restorecommands accepted unvalidated user input for the snapshot name, which was directly passed toPath::join(). This allowed a path traversal attack (e.g.,../etc/passwd) to read or overwrite arbitrary files on the user's system under the context of the running application.π― Impact: An attacker could overwrite critical system files or expose sensitive data by providing malicious path traversals as snapshot names.
π§ Fix: Implemented an explicit allowlist validation
crate::utils::validate_file_namethat restricts input to alphanumeric characters, dashes, and underscores. This validation is now enforced for all snapshot names prior to joining with the snapshot directory path.β Verification:
cargo testconfirms the path validation rejects any input containing.or/, ensuring safe path execution.PR created automatically by Jules for task 6644483708482754008 started by @bitcoiner-dev