chore: dedupe parse_duration_to_seconds across sync and traces#181
Merged
Cedric / ViaDézo1er (viadezo1er) merged 1 commit intoMay 13, 2026
Conversation
Re-applies the deduplication from d72671d that was inadvertently undone by the unicode-safety fix in 29191c0. Both sync.rs and traces.rs now import the canonical implementation from utils::duration instead of carrying their own copies, and utils/mod.rs re-exports the helper. Resolves the dead_code warning reported in #180. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Cedric / ViaDézo1er (viadezo1er)
requested a review
from Parker Henderson (parkerhendo)
Andrew Kent (realark)
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies the deduplication from d72671d that was inadvertently undone by the unicode-safety fix in 29191c0. Both
sync.rsandtraces.rsnow import the canonical implementation fromutils::durationinstead of carrying their own copies, andutils/mod.rsre-exports the helper.Resolves the dead_code warning reported in #180.