[APS-18945, APS-18946] fix: bump org.json and testng to patch security vulnerabilities#4
Open
karanshah-browserstack wants to merge 2 commits intomainfrom
Open
Conversation
…S [APS-18945, APS-18946] - Bump org.json:json from 20210307 to 20231013 (fixes CVE stack overflow / DoS — APS-18945) - Bump org.testng:testng from 7.4.0 to 7.5.1 (fixes path traversal vulnerability — APS-18946) Resolves: APS-18945, APS-18946
…18945] [APS-18946] - Replace StandardCharsets.UTF_8 (Charset) with "UTF-8" (String) in URLEncoder.encode calls — the Charset overload requires Java 10+ - Add throws Exception to @before setUp methods to satisfy the checked UnsupportedEncodingException declaration - Pre-existing compilation failure on main branch; unrelated to the dependency version bumps in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix: APS-18945 + APS-18946
Issues Fixed
Root Cause
Both dependencies were pinned to old, vulnerable versions in `pom.xml`:
Fix Applied
Single `pom.xml` change bumping both version properties:
```
<testng.version>7.4.0</testng.version> → <testng.version>7.5.1</testng.version>
<json.version>20210307</json.version> → <json.version>20231013</json.version>
```
Testing
Dependency Resolution (fix branch):
Compilation (fix branch):
BrowserStack E2E Session Run (karanshah14's account):
Jira Tickets
Checklist