Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | -44 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a significant maintainability risk due to high cyclomatic complexity (CCN 16) in the issues command handler. The addition of manual pagination and batching logic for the bulk-ignore feature has made the main action handler difficult to test and maintain.
Furthermore, the Node.js engine requirement has been bumped from version 18 to 20. As this is currently a patch version update (1.0.4 to 1.0.5), this constitutes a breaking change for users on the previous LTS version without a corresponding major version bump. This violation of SemVer should be resolved by either reverting the requirement or promoting the release to a major version.
Test suggestions
- Verify that --false-positives flag correctly sets onlyPotentialFalsePositives in the API request body.
- Verify that --bulk-ignore fetches all pages of issues before starting the ignore process.
- Verify that bulk-ignore batches IDs into groups of 100 to avoid API payload limits.
- Verify that custom comments are correctly passed to the bulk-ignore API call.
- Verify that bulk-ignore respects other active filters like --branch and --patterns.
- Verify behavior when no false positive issues are found (graceful exit with message).
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
There was a problem hiding this comment.
Pull request overview
Adds false-positive workflows to the issues CLI command so repository issues can be filtered to likely FPs and bulk-ignored, with supporting test coverage and API schema version updates.
Changes:
- Added
--false-positives,--bulk-ignore, and--commenthandling toissues. - Added tests for FP filtering, bulk-ignore batching, and comment forwarding.
- Updated the API schema source version and refreshed lockfile metadata.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/commands/issues.ts |
Adds FP-only filtering and batched repository bulk-ignore behavior. |
src/commands/issues.test.ts |
Covers the new flags and batching/comment behavior. |
package.json |
Points fetch-api to a newer API schema bundle. |
package-lock.json |
Refreshes package metadata/lockfile after the dependency/script changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8fce1c2 to
68739aa
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
68739aa to
095445e
Compare
Add filtering issues that are false-positive. And command to bulk ignore false-positives