Skip to content

feat: Add filter and bulk-ignore for FP CF-2412#5

Open
og-pixel wants to merge 2 commits intomainfrom
feat/CF-2412-filter
Open

feat: Add filter and bulk-ignore for FP CF-2412#5
og-pixel wants to merge 2 commits intomainfrom
feat/CF-2412-filter

Conversation

@og-pixel
Copy link
Copy Markdown

@og-pixel og-pixel commented May 5, 2026

Add filtering issues that are false-positive. And command to bulk ignore false-positives

Copilot AI review requested due to automatic review settings May 5, 2026 10:19
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 5, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -44 duplication

Metric Results
Duplication -44

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown

@codacy-production codacy-production Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a significant maintainability risk due to high cyclomatic complexity (CCN 16) in the issues command handler. The addition of manual pagination and batching logic for the bulk-ignore feature has made the main action handler difficult to test and maintain.

Furthermore, the Node.js engine requirement has been bumped from version 18 to 20. As this is currently a patch version update (1.0.4 to 1.0.5), this constitutes a breaking change for users on the previous LTS version without a corresponding major version bump. This violation of SemVer should be resolved by either reverting the requirement or promoting the release to a major version.

Test suggestions

  • Verify that --false-positives flag correctly sets onlyPotentialFalsePositives in the API request body.
  • Verify that --bulk-ignore fetches all pages of issues before starting the ignore process.
  • Verify that bulk-ignore batches IDs into groups of 100 to avoid API payload limits.
  • Verify that custom comments are correctly passed to the bulk-ignore API call.
  • Verify that bulk-ignore respects other active filters like --branch and --patterns.
  • Verify behavior when no false positive issues are found (graceful exit with message).

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread src/commands/issues.ts
Comment thread package-lock.json
Comment thread src/commands/issues.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds false-positive workflows to the issues CLI command so repository issues can be filtered to likely FPs and bulk-ignored, with supporting test coverage and API schema version updates.

Changes:

  • Added --false-positives, --bulk-ignore, and --comment handling to issues.
  • Added tests for FP filtering, bulk-ignore batching, and comment forwarding.
  • Updated the API schema source version and refreshed lockfile metadata.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/commands/issues.ts Adds FP-only filtering and batched repository bulk-ignore behavior.
src/commands/issues.test.ts Covers the new flags and batching/comment behavior.
package.json Points fetch-api to a newer API schema bundle.
package-lock.json Refreshes package metadata/lockfile after the dependency/script changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/commands/issues.ts Outdated
Comment thread src/commands/issues.ts Outdated
Comment thread src/commands/issues.ts Outdated
Copilot AI review requested due to automatic review settings May 5, 2026 11:18
@og-pixel og-pixel force-pushed the feat/CF-2412-filter branch from 8fce1c2 to 68739aa Compare May 5, 2026 11:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/commands/issues.ts
Comment thread src/commands/issues.ts
Comment thread src/commands/issues.ts
Comment thread src/commands/issues.test.ts Outdated
@og-pixel og-pixel force-pushed the feat/CF-2412-filter branch from 68739aa to 095445e Compare May 5, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants