Bump ReverseMarkdown from 3.19.0 to 4.7.1#128
Conversation
--- updated-dependencies: - dependency-name: ReverseMarkdown dependency-version: 4.7.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
.NET
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This upgrade from ReverseMarkdown 3.19.0 to 4.7.1 is critical for resolving an exponential time complexity bug (GH-408) and adding Slack-flavored markdown support. However, the upgrade introduces a breaking change in version 4.3.0 where 'SuppressNewlines' was renamed to 'SuppressDivNewlines'. Furthermore, version 4.0.0 removed support for older .NET targets (net46 and net5.0). While the Codacy analysis indicates the PR is up to standards, these architectural and configuration risks must be manually verified to ensure project stability.
About this PR
- The ReverseMarkdown library renamed the 'SuppressNewlines' configuration option to 'SuppressDivNewlines' in version 4.3.0. Any existing usage of this setting must be updated to avoid configuration errors or unexpected output behavior.
- Support for .NET 4.6 and .NET 5.0 was removed in version 4.0.0. Please confirm that the consuming project targets a compatible framework, such as .NET Standard 2.0 or .NET 6/7/8.
Test suggestions
- Ensure the project builds successfully with the updated library version.
- Verify that any usage of the configuration 'SuppressNewlines' is updated to 'SuppressDivNewlines' (breaking change introduced in v4.3.0).
- Validate that nested
tags do not cause performance hangs (regression test for GH-408).
- Verify support for new conversion elements like and strikethrough (s, del, strike).
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Ensure the project builds successfully with the updated library version.
2. Verify that any usage of the configuration 'SuppressNewlines' is updated to 'SuppressDivNewlines' (breaking change introduced in v4.3.0).
3. Validate that nested <p> tags do not cause performance hangs (regression test for GH-408).
4. Verify support for new conversion elements like <sup> and strikethrough (s, del, strike).
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Updated ReverseMarkdown from 3.19.0 to 4.7.1.
Release notes
Sourced from ReverseMarkdown's releases.
4.7.1
Fix Exponential Time Complexity Bug Causing Hangs with Nested
<p>Tags GH-408 by @ssperling-wmp (cherry-picked and merged from master)Full Changelog: mysticmind/reversemarkdown-net@4.7.0...4.7.1
4.7.0
What's Changed
New Contributors
Full Changelog: mysticmind/reversemarkdown-net@4.6.0...4.7.0
4.6.0
What's Changed
New Contributors
Full Changelog: mysticmind/reversemarkdown-net@4.5.0...4.6.0
4.5.0
Full Changelog: mysticmind/reversemarkdown-net@4.4.0...4.5.0
4.4.0
Full Changelog: mysticmind/reversemarkdown-net@4.3.0...4.4.0
4.3.0
SuppressNewlinestoSuppressDivNewlines. Note that 4.2.0 was published with incorrect name so unlisted it rather than bumping up the major version due to this change.Full Changelog: mysticmind/reversemarkdown-net@4.2.0...4.3.0
4.2.0
What's Changed
Note: NuGet version unlisted due to incorrect config name, see 4.3.0 for details.
New Contributors
Full Changelog: mysticmind/reversemarkdown-net@4.1.0...4.2.0
4.1.0
Whats Changed
s,delandstrike#356Full Changelog: mysticmind/reversemarkdown-net@4.0.0...4.1.0
4.0.0
What's Changed
<sup>tag conversion by @francescolf in Add support for <sup> tag conversion mysticmind/reversemarkdown-net#358New Contributors
Full Changelog: mysticmind/reversemarkdown-net@3.25.0...4.0.0
3.25.0
Full Changelog: mysticmind/reversemarkdown-net@3.24.0...3.25.0
3.24.0
What's Changed
Full Changelog: mysticmind/reversemarkdown-net@3.23.1...3.24.0
Milestone: https://github.com/mysticmind/reversemarkdown-net/milestone/24?closed=1
3.23.1
Full Changelog: mysticmind/reversemarkdown-net@3.23.0...3.23.1
3.23.0
Full Changelog: mysticmind/reversemarkdown-net@3.22.0...3.23.0
3.22.0
Full Changelog: mysticmind/reversemarkdown-net@3.21.0...3.22.0
3.21.0
Full Changelog: mysticmind/reversemarkdown-net@3.20.0...3.21.0
3.20.0
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)