Improve interaction of badge column and editable text selection#2420
Merged
Conversation
Collapse editor.selection to the start of the clicked thread on badge click so that downstream consumers (commentThreadIdsAtSelection in transient state, the comments-mode switch-out check) see the cursor's block as the thread's block. Slate-react only mirrors editor.selection to the DOM while the editor is focused, but the badge lives in a floating portal, so the click moves focus to the badge button and the sync is skipped — the user's prior text selection stays visibly painted even though slate's state is correctly collapsed. We do not clear the DOM selection ourselves either: a removeAllRanges call fires a selectionchange that slate- react's listener uses to overwrite editor.selection back to null, which would undo this transform and drop the selection rect. The visible text selection therefore lingers until the user's next interaction with the editor; that's an acceptable trade since the slate state stays correct for everything downstream.
tf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDMINE-21261