[filesystems] Replace "encoded character type" with "character type" from the core wording#8158
Open
frederick-vs-ja wants to merge 3 commits intocplusplus:mainfrom
Open
Conversation
jensmaurer
approved these changes
Aug 15, 2025
Member
jensmaurer
left a comment
jensmaurer
left a comment
There was a problem hiding this comment.
Feels like a simplification.
@jwakely ?
Contributor
|
See https://eel.is/c++draft/basic.fundamental#11.sentence-1 for characater types. @jwakely? |
Contributor
|
Could it be that the term "character type" was only introduced by https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2314r4.html in 2021, long after the Filesystem wording was made? So maybe this is just missed cleanup |
jwakely
requested changes
Nov 17, 2025
tkoeppe
added
the
changes requested
frederick-vs-ja
force-pushed
the
encoded-core-character-types
branch
from
3bd95fd to
2dc2735
Compare
Contributor
Author
frederick-vs-ja
force-pushed
the
encoded-core-character-types
branch
from
2dc2735 to
1364579
Compare
wg21bot
added
the
needs rebase
frederick-vs-ja
force-pushed
the
encoded-core-character-types
branch
from
1364579 to
3a0c4c4
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terms "encoded character type(s)" (introduced in [fs.req]) and "character type(s)" (introduced in [basic.fundamental]) mean exactly the same set of types. It's probably better to avoid such duplicate. And the current preference seems to be using "character type" throughout the library wording, rather than renaming the term in the core wording.
Closes #5638.