Fix #1473: warn when fclose() is used as a while loop condition#8444
Open
francois-berder wants to merge 6 commits intocppcheck-opensource:mainfrom
Open
Fix #1473: warn when fclose() is used as a while loop condition#8444francois-berder wants to merge 6 commits intocppcheck-opensource:mainfrom
francois-berder wants to merge 6 commits intocppcheck-opensource:mainfrom
Conversation
|
danmar
reviewed
Apr 25, 2026
danmar
reviewed
Apr 28, 2026
…oop condition Using fclose() as a while loop condition closes the file on every iteration and operates on an already-closed file handle from the second iteration onward. Signed-off-by: Francois Berder <fberder@outlook.fr>
…while loop condition
…d as a while loop condition
… is used as a while loop condition
…close() is used as a while loop condition
francois-berder
force-pushed
the
pr-1473
branch
from
3491db9 to
28f2247
Compare
danmar
reviewed
Apr 30, 2026
… when fclose() is used as a while loop condition
danmar
reviewed
May 4, 2026
| { | ||
| reportError(tok, Severity::warning, | ||
| "fcloseInLoopCondition", | ||
| "fclose() should not be used as a loop condition.\n" |
Collaborator
There was a problem hiding this comment.
could there be some safe usage where fclose is used in the loop condition by intention:
while (fclose(f)) {
..dostuff..
f = fopen(..);
}
it would be interesting if you would run test-my-pr.py and see if we generate any warnings..
Collaborator
There was a problem hiding this comment.
let's consider how to make the short message a bit more specific about what problems there are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using fclose() as a while loop condition closes the file on every iteration and operates on an already-closed file handle from the second iteration onward.