Skip to content

Add an output to the action to give the version#6

Open
aurelien-reeves wants to merge 1 commit intocucumber:mainfrom
aurelien-reeves:output-next-version
Open

Add an output to the action to give the version#6
aurelien-reeves wants to merge 1 commit intocucumber:mainfrom
aurelien-reeves:output-next-version

Conversation

@aurelien-reeves
Copy link
Copy Markdown

No description provided.

@mattwynne
Copy link
Copy Markdown
Member

Ideally we'd update the README too.

@mattwynne
Copy link
Copy Markdown
Member

It's worth noting that we can also use the https://github.com/cucumber-actions/versions action separately to look up the current / next release versions if we need them.

I still think this is useful though 👍

@mattwynne
Copy link
Copy Markdown
Member

We should also update the changelog in this PR! 😁

@mattwynne
Copy link
Copy Markdown
Member

I can't modify this PR as it's in a fork...

@aslakhellesoy
Copy link
Copy Markdown

aslakhellesoy commented Sep 22, 2021

It had to be a fork since only you have write access to this org @mattwynne - can you (re)-invite @aurelien-reeves and me please?

@mattwynne
Copy link
Copy Markdown
Member

It had to be a fork since only you have write access to this org @mattwynne - can you (re)-invite @aurelien-reeves and me please?

grrr. Aurelien has accepted his invite and was a "Member", I've just promoted him to "Owner". Maybe this was the problem?

Screenshot 2021-09-22 at 3 02 58 PM

You still need to accept your invite Aslak. I re-sent it yesterday. I think you should be able to see it at https://github.com/cucumber-actions, no?

@aurelien-reeves
Copy link
Copy Markdown
Author

I can't modify this PR as it's in a fork...

You should be able to. You just have to add the proper remote. Or maybe even just with git push aurelien-reeves/create-release output-next-version (did not tested that last command) as mentioned by github: "Add more commits by pushing to the output-next-version branch on aurelien-reeves/create-release."

@aurelien-reeves
Copy link
Copy Markdown
Author

grrr. Aurelien has accepted his invite and was a "Member", I've just promoted him to "Owner". Maybe this was the problem?

You still need to accept your invite Aslak. I re-sent it yesterday. I think you should be able to see it at https://github.com/cucumber-actions, no?

Why those actions are into a dedicated organization and not in the cucumber one?

@mattwynne
Copy link
Copy Markdown
Member

mattwynne commented Sep 23, 2021

Why those actions are into a dedicated organization and not in the cucumber one?

I was thinking the same thing! Let's move them over to cucumber.

@mattwynne
Copy link
Copy Markdown
Member

OK they've all moved into the cucumber org!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants