Update cuenca-validations to version 2.1.31.dev0, increment internal …#440
Update cuenca-validations to version 2.1.31.dev0, increment internal …#440rcabrera-py wants to merge 5 commits into
Conversation
…version to 2.1.20.dev0, and add PasswordReset resource with tests.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (3)
WalkthroughAdds a new PasswordReset Creatable resource (endpoint "password_resets") with fields for platform_id, flow_id, status, optional provider_url, and timestamps, plus a create(location, session) classmethod that posts a PasswordResetRequest. Registers and exports PasswordReset from cuenca.resources and re-exports it at package root. Adds a pytest VCR integration test and cassette for POST /password_resets. Bumps version to 2.2.0.dev3 and updates cuenca-validations to 2.1.31. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cuenca/http/client.py`:
- Line 21: SANDBOX_HOST is incorrectly set to the same value as API_HOST so
configure(sandbox=True) doesn't switch environments; restore a distinct sandbox
hostname by changing the SANDBOX_HOST assignment (symbol SANDBOX_HOST in
cuenca/http/client.py) back to the sandbox-specific host used by the service and
ensure configure(sandbox=True) uses SANDBOX_HOST instead of API_HOST (refer to
the configure(sandbox=True) logic and any host-selection code that reads
API_HOST/SANDBOX_HOST).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f579c9db-d1a0-4fa8-a059-4ca9028b44df
📒 Files selected for processing (7)
cuenca/__init__.pycuenca/http/client.pycuenca/resources/__init__.pycuenca/resources/password_resets.pycuenca/version.pyrequirements.txttests/resources/test_password_resets.py
…_id from PasswordReset resource, and adjust related tests.
rcabrera-py
force-pushed
the
feat/add-reset-password
branch
from
ea039ae to
8663f46
Compare
…PasswordReset resource, and add test cassette for password reset creation.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/resources/test_password_resets.py`:
- Around line 7-15: The VCR cassette for the test_password_resets_create test is
recorded against the old host and must be re-recorded to match the new sandbox
host; re-run the test that contains test_password_resets_create with VCR set to
record a new cassette (or temporarily set record mode to "all"/"new_episodes"),
accept the new interaction so the cassette captures POST
https://sandbox.cuenca.com/password_resets, then commit the updated cassette so
future runs (RecordMode.ONCE) use the new host; ensure the re-recorded cassette
contains the POST to the sandbox URL referenced by PasswordReset.create and
verify the test passes before pushing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c4930be3-5d1e-4883-b3c3-bd8956d47045
📒 Files selected for processing (3)
cuenca/resources/password_resets.pytests/resources/cassettes/test_password_resets_create.yamltests/resources/test_password_resets.py
✅ Files skipped from review due to trivial changes (1)
- tests/resources/cassettes/test_password_resets_create.yaml
…sword reset creation to use sandbox environment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 54 55 +1
Lines 1199 1222 +23
=========================================
+ Hits 1199 1222 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
….0.dev3, and remove mati_verification_id and identity_id from PasswordReset resource. Adjust test cassette for password reset creation accordingly.
3 participants
…version to 2.1.20.dev0, and add PasswordReset resource with tests.
Summary by CodeRabbit
New Features
Tests
Chores