CM-63882 - Added scanType validation#452
Open
aaron-butler-cy-int wants to merge 3 commits into
Open
Conversation
aaron-butler-cy-int
requested review from
elsapet,
gotbadger and
mateusz-sterczewski
as code owners
Comment on lines
+129
to
+137
| if len(scan_type) > 1: | ||
| raise typer.BadParameter( | ||
| f'Only one scan type can be specified per command. ' | ||
| f'Got: {", ".join(str(t) for t in scan_type)}. ' | ||
| f'Run a separate command for each scan type.', | ||
| param_hint='-t/--scan-type', | ||
| ) | ||
|
|
||
| resolved_scan_type = scan_type[0] |
Collaborator
There was a problem hiding this comment.
Try using a parameter callback to perform the validation, we can then reuse it later:
https://typer.tiangolo.com/tutorial/options/callback-and-context/
omerr-cycode
requested changes
May 13, 2026
Co-authored-by: omerr-cycode <omer.roth@cycode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the scan command use to accept multiple -t flags but would only run the last scan listed in the command. Added validation that only one -t flag was in the command.