Start to build using Makefiles by danrmiller · Pull Request #1336 · cypherstack/stack_wallet

danrmiller · 2026-05-13T01:49:36Z

Courtesy of ongoing work by @parasew this introduces Nix flake + Makefile towards eventual reproducible builds.

Adds a flake.nix dev shell with pinned nixpkgs for reproducible Flutter/Rust toolchain
Adds a comprehensive Makefile as the single build entry point for all platforms
Adds macOS build patches for Nix+Xcode interop (lipo/xcrun wrappers)
Adds an MWC FFI integration test suite (~1000 lines)
Pins Rust toolchains to stable + 1.85.1 (drops 1.81.0 and 1.89.0)
Bumps macos deployment target from 10.15 to 11.0
Adds a macos smoke-build CI job

…r icons Co-authored-by: sneurlax <sneurlax@gmail.com>

…lity

Co-authored-by: sneurlax <sneurlax@gmail.com>

…stack.stackduo (fixes invalid bundle-id chars)

…ches

…e boilerplate

…egeneration

…de*.app and switches xcode-select to it, so the CI runner uses the full Xcode SDK instead of CLI tools.

…ow-sdk-path actually resolves

codecov · 2026-05-13T20:17:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.93%. Comparing base (cf7251b) to head (8b0e24c).
⚠️ Report is 1 commits behind head on staging.

Additional details and impacted files

@@           Coverage Diff            @@
##           staging    #1336   +/-   ##
========================================
  Coverage     4.93%    4.93%           
========================================
  Files         1064     1064           
  Lines       107980   107980           
========================================
+ Hits          5328     5330    +2     
+ Misses      102652   102650    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

danrmiller

Will discuss on call with @parasew

danrmiller · 2026-05-13T21:26:56Z

+						"\"${DT_TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}\"",
+						/usr/lib/swift,
+					);
+					PRODUCT_MODULE_NAME = stack_wallet;


Per @julian-CStack since its a template, stack_wallet should not be found in this file. If thats an updated requirement for newer macos or general macos builds we'll need to update the template to actual gen scripts to update it on copy

danrmiller · 2026-05-13T21:28:51Z

 export NEW_APP_ID="com.cypherstack.stackduo"
 export NEW_APP_ID_CAMEL="com.cypherstack.stackDuo"
-export NEW_APP_ID_SNAKE="com.cypherstack.stack_duo"
+export NEW_APP_ID_SNAKE="com.cypherstack.stackduo"


@julian-CStack is unsure about the purpose of this change as the bash var is specifically called snake case id.

…job to Makefile make build-macos now drives the full macOS release build via the Makefile, replacing the old build_app.sh -d -s download path with source compilation. build.yaml: remove redundant Configure/GetDeps/GitVersions/Build steps now handled by make build-macos. Add dtolnay/rust-toolchain@stable + 1.85.1 install so check-reqs passes. Makefile: test-mwc now ensures local stable rustup toolchain is installed and defaulted before flutter test -d macos, fixing missing flutter_libsparkmobile framework linker error when Cargokit rebuilds for Debug mode.

julian-CStack

I know this is still a WIP and I've just done a rough scan of things and haven't fully gone over the main Makefile yet either

In general I do not like patching dependencies if it can be helped and since we control many of the deps I think it would be better to change those and simplify this build process if possible

julian-CStack · 2026-05-14T13:21:29Z

This should be reverted.
flutter pub run was replaced by dart run quite a while ago.

julian-CStack · 2026-05-14T13:34:51Z

-if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
-  set(CMAKE_INSTALL_PREFIX "${BUILD_BUNDLE_DIR}" CACHE PATH "..." FORCE)
-endif()
+# Always install into the local build bundle. On NixOS and other constrained


I'm not 100% sure but I don't think this should get changed. I've seen permission to install failures when running projects locally sometimes but that is generally some kind of cache issue or config issue. I don't remember the details as it was a while ago when I ran into this last

julian-CStack · 2026-05-14T13:35:16Z

+						"\"${DT_TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}\"",
+						/usr/lib/swift,
+					);
+					PRODUCT_MODULE_NAME = stack_wallet;


same thing here https://github.com/cypherstack/stack_wallet/pull/1336/changes#r3237549621

julian-CStack · 2026-05-14T13:38:10Z


+if [[ ! -f "${PUBSPEC_FILE}" ]]; then
+  echo "Error: pubspec.yaml not found at ${PUBSPEC_FILE}" >&2
+  echo "Run from repo root and restore it with: git checkout -- pubspec.yaml" >&2


This is wrong. The pubspec.yaml is generated, not pulled form git.

julian-CStack · 2026-05-14T13:38:33Z

-else
-  sed -i "s/name: PLACEHOLDER/name: ${NEW_PUBSPEC_NAME}/g" "${PUBSPEC_FILE}"
-  sed -i "s/description: PLACEHOLDER/description: ${NEW_NAME}/g" "${PUBSPEC_FILE}"
+if [[ ! -f "${PUBSPEC_FILE}" ]]; then


This is wrong. The pubspec.yaml is generated, not pulled form git.

julian-CStack · 2026-05-14T13:48:49Z

Any reason these changes could not be directly PR'd to flutter_libmwc?

julian-CStack · 2026-05-14T13:50:22Z

 fi

+# Keep macOS stack_wallet builds on the Makefile path so setup steps stay in one place.
+if [ "$APP_BUILD_PLATFORM" = "macos" ] && [ "$APP_NAMED_ID" = "stack_wallet" ]; then


Any reason this only applies to stack_wallet and not others?

julian-CStack · 2026-05-14T14:10:30Z

+		$(FLUTTER) config --enable-macos-desktop >/dev/null
+	@# Reassert macOS platform metadata in the same local HOME used for the final build.
+	@env HOME="$(PROJECT_HOME)" XDG_CACHE_HOME="$(PROJECT_CACHE)" TMPDIR="$(PROJECT_TMP)" PUB_CACHE="$(PUB_CACHE)" \
+		$(FLUTTER) create --platforms=macos . --no-pub >/dev/null


I don't think flutter create --platforms=macos should be called on build

julian-CStack · 2026-05-14T14:14:04Z

+	@echo "--- Building app..."
+	@if [ ! -f lib/external_api_keys.dart ]; then \
+		echo "[WARN] lib/external_api_keys.dart missing; recreating template."; \
+		printf 'const kChangeNowApiKey = "";\nconst kSimpleSwapApiKey = "";\nconst kNanswapApiKey = "";\nconst kNanoSwapRpcApiKey = "";\nconst kWizSwapApiKey = "";\n' > lib/external_api_keys.dart; \


This is redundant as the prebuild.sh script will generate this here https://github.com/cypherstack/stack_wallet/pull/1336/changes#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R399

If a check must be done here, better to fail with an error to check that prebuild.sh worked correctly

julian-CStack · 2026-05-14T14:16:46Z

+	@cp scripts/patches/flutter_libmwc_macos_build_all.sh crypto_plugins/flutter_libmwc/scripts/macos/build_all.sh
+	@chmod +x crypto_plugins/flutter_libmwc/scripts/macos/build_all.sh
+	@# Ensure Frostdart macOS build script uses sed -i.bak form (GNU/BSD compatibility).
+	@perl -0777 -i.bak -pe 's/_run\("sed",\s*\["-i"\s*,\s*"\.bak"\s*,\s*"s\/frostdart\/hrf-api\/",\s*"cargo\.toml"\]\);/_run("sed", ["-i.bak", "s\/frostdart\/hrf-api\/", "cargo.toml"]);/g' crypto_plugins/frostdart/scripts/macos/build_macos.dart 2>/dev/null || true


better to fix at source rather than patch

…igure this can be reverted/dropped after the legacy build scripts are deprecated

Lunar Dev and others added 30 commits May 11, 2026 22:29

fix(scripts): make sed commands portable for GNU and BSD variants

af4a59e

fix(scripts): use 'flutter pub run' instead of 'dart run' for launche…

2cbb5aa

…r icons Co-authored-by: sneurlax <sneurlax@gmail.com>

feat(nix): introduce flake-based dev shell for guaranteed reproducibi…

81f427d

…lity

feat(makefile): build management

e6be04e

fixing flake

010eadd

submodules fix and macOs specific nix fixes

5f9a8ce

adding changes for successful macOs run

4454920

fixing part in last build step (dropping flags)

6ce520a

adding linux parts

1d48641

Co-authored-by: sneurlax <sneurlax@gmail.com>

removing overrides

7759828

adding better clean

f204511

macos makefile fixes

e62c261

up

6ba1741

nixos fixes

5c43045

Makefile fixes

b2a90e7

makefile fixes

90c08b8

makefile fixes

9768ea5

makefile fixes

e1a9c78

successful macOS build

62db43c

fixing env bash calls for nixos

52ce806

Co-authored-by: sneurlax <sneurlax@gmail.com>

macOS build split into phases

ed122ef

NEW_APP_ID_SNAKE changed from com.cypherstack.stack_duo to com.cypher…

ebb3774

…stack.stackduo (fixes invalid bundle-id chars)

adding direnv and macOS build tools install helper script

795a993

Replaced exit 1 with echo 'Bypassed by Nix' in missing-toolchain bran…

a0c85bd

…ches

fixing current repo path for APP_PROJECT_ROOT_DIR

3bf60c0

scripts now compute project root from their own location

fa14da7

adding pubspec.yaml creation to macos-configure

380874e

git submodule update --init --recursive for macos-configure

0ca3fb1

fixing xelis_dart_sdk version bug

6abc46c

fixing wrong formatting of xelis_dart_sdk yaml

a3b3022

Lunar Dev and others added 12 commits May 11, 2026 22:32

gitignore: ignore generated CodexOverrides.xcconfig and flutter-creat…

b4f7565

…e boilerplate

build(macos): remove flutter-create boilerplate test after platform r…

6b72f09

…egeneration

flake(nix): pin Rust to stable + 1.85.1 and ensure clang symlinks

0f17367

add MWC FFI integration smoke test and make test-mwc target

94e10ec

add MWC FFI integration smoke test and make test-mwc target (2)

59975f2

fix(macos): bundle GNU rsync in flake to fix release_unpack_macos

dba97dc

build(macos): commit CodexOverrides.xcconfig include lines

cac32a1

build(nix): pin nixpkgs rev for reproducible toolchain

bbf41dc

Merge remote-tracking branch 'origin/staging' into feat/make

ca05bf1

Add a Select Xcode step before the build that finds /Applications/Xco…

936192b

…de*.app and switches xcode-select to it, so the CI runner uses the full Xcode SDK instead of CLI tools.

CI: Change check-macos-sdk to validating that xcrun --sdk macosx --sh…

594d230

…ow-sdk-path actually resolves

Update dart formatting for libmwc integration tests

75ed4bc

Merge branch 'staging' into feat/make

18b79fc

danrmiller marked this pull request as ready for review May 13, 2026 21:11

danrmiller requested a review from julian-CStack May 13, 2026 21:12

danrmiller commented May 13, 2026

View reviewed changes

danrmiller added 6 commits May 13, 2026 14:35

Run MWC integration tests

411f4dc

fix(linux): reconcile secp256k1 build script with staging

6d9566a

Merge branch 'staging' into feat/make

1d9635d

Use nix flake for macos builds

54e9ea0

Add protobuf to common packages and export PROTOC on macOS in nix flake

4777452

julian-CStack reviewed May 14, 2026

View reviewed changes

julian-CStack marked this pull request as draft May 14, 2026 14:21

danrmiller and others added 3 commits May 14, 2026 08:41

Forward PROTOC into macos-build-native env

a84d5ad

fix(make): always regenerate pubspec.yaml from template in macos-conf…

f680859

…igure this can be reverted/dropped after the legacy build scripts are deprecated

chore(deps): refresh pubspec.lock against updated bip47 ref

8b0e24c

sneurlax force-pushed the feat/make branch from 07cc49e to 8b0e24c Compare May 14, 2026 16:28

Conversation

danrmiller commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

danrmiller left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

julian-CStack left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danrmiller commented May 13, 2026 •

edited

Loading

codecov Bot commented May 13, 2026 •

edited

Loading