Conversation
go/exec/doc.go: package-comment had `os/exec` in backticks, which the
audit regex flags as a banned import (it scans .go files for `("|`)<stdlib-name>("|`)`
to catch backtick-quoted import dodges). The actual import was never there —
just stdlib-name prose inside doc tags.
Reworded to "wraps stdlib process spawning with a Result-shaped API" — same
information, no banned-stdlib name appearing in backticks.
Verification:
- audit.sh -> COMPLIANT (0 findings)
- GOWORK=off go build ./... clean
- GOWORK=off go vet ./... clean
- GOWORK=off go test ./exec/ pass
- GOWORK=off gofmt -l . clean
Closes tasks.lthn.sh/view.php?id=1328
Filed-by: hephaestus
Co-authored-by: Hephaestus <hephaestus@lthn.ai>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe package-level documentation for Changes
Review rate limit: 1/5 review remaining, refill in 41 minutes and 43 seconds. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit COMPLIANT. Closes Mantis #1328.
Summary by CodeRabbit