Skip to content

cmdio: wrap promptui so callers stop importing it directly#5174

Open
pietern wants to merge 2 commits intomainfrom
drop-promptui-imports
Open

cmdio: wrap promptui so callers stop importing it directly#5174
pietern wants to merge 2 commits intomainfrom
drop-promptui-imports

Conversation

@pietern
Copy link
Copy Markdown
Contributor

@pietern pietern commented May 4, 2026

Summary

  • Add cmdio.SelectOptions/RunSelect and cmdio.PromptOptions/RunPrompt as a neutral surface around promptui.
  • Migrate 4 RunSelect callers and 6 Prompt callers across cmd/auth, cmd/configure, and libs/databrickscfg. After this change, promptui is only imported under libs/cmdio, making a future swap of the prompt library a one-package change.
  • Behavior is unchanged.

This pull request and its description were written by Isaac.

pietern added 2 commits May 4, 2026 16:24
Introduces cmdio.SelectOptions/RunSelect and cmdio.PromptOptions/RunPrompt
as a neutral surface around promptui, and migrates the four RunSelect
callers and six Prompt callers across cmd/auth, cmd/configure, and
libs/databrickscfg. Only libs/cmdio (and warehouses.go, deferred)
import promptui directly now, making it cheap to swap the underlying
library later.

Co-authored-by: Isaac
The bundle_test profile-prompt assertion still depends on
StartInSearchMode emitting "Search:" first, but the wording
should point at the cmdio API now that callers no longer see
promptui directly.

Co-authored-by: Isaac
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Approval status: pending

/cmd/auth/ - needs approval

4 files changed
Suggested: @simonfaltum
Also eligible: @tanmay-db, @mihaimitrea-db, @tejaskochar-db, @hectorcast-db, @renaudhartert-db, @parthban-db, @Divyansh-db, @chrisst, @rauchy

/cmd/configure/ - needs approval

Files: cmd/configure/configure.go
Suggested: @simonfaltum
Also eligible: @tanmay-db, @mihaimitrea-db, @tejaskochar-db, @hectorcast-db, @renaudhartert-db, @parthban-db, @Divyansh-db, @chrisst, @rauchy

/cmd/root/ - needs approval

Files: cmd/root/bundle_test.go
Suggested: @simonfaltum
Also eligible: @tanmay-db, @mihaimitrea-db, @tejaskochar-db, @hectorcast-db, @renaudhartert-db, @parthban-db, @Divyansh-db, @chrisst, @rauchy

/libs/cmdio/ - needs approval

Files: libs/cmdio/io.go, libs/cmdio/prompt.go, libs/cmdio/select.go
Suggested: @simonfaltum
Also eligible: @tanmay-db, @mihaimitrea-db, @tejaskochar-db, @hectorcast-db, @renaudhartert-db, @parthban-db, @Divyansh-db, @chrisst, @rauchy

/libs/databrickscfg/ - needs approval

Files: libs/databrickscfg/cfgpickers/clusters.go, libs/databrickscfg/profile/profile.go, libs/databrickscfg/profile/select.go
Suggested: @simonfaltum
Also eligible: @tanmay-db, @mihaimitrea-db, @tejaskochar-db, @hectorcast-db, @renaudhartert-db, @parthban-db, @Divyansh-db, @chrisst, @rauchy

Any maintainer (@andrewnester, @anton-107, @denik, @shreyas-goenka, @simonfaltum, @renaudhartert-db) can approve all areas.
See OWNERS for ownership rules.

@pietern pietern temporarily deployed to test-trigger-is May 4, 2026 14:31 — with GitHub Actions Inactive
@pietern pietern temporarily deployed to test-trigger-is May 4, 2026 14:31 — with GitHub Actions Inactive
@pietern pietern requested a review from simonfaltum May 4, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant