Skip to content

cmdio: drop unused PromptOptions.AllowEdit#5177

Open
pietern wants to merge 1 commit intodrop-promptui-importsfrom
drop-prompt-allowedit
Open

cmdio: drop unused PromptOptions.AllowEdit#5177
pietern wants to merge 1 commit intodrop-promptui-importsfrom
drop-prompt-allowedit

Conversation

@pietern
Copy link
Copy Markdown
Contributor

@pietern pietern commented May 4, 2026

Summary

AllowEdit only affects how promptui renders a non-empty Default: with AllowEdit:true the default pre-fills the buffer; with AllowEdit:false it appears as a placeholder that's wiped on first keystroke. No caller in the repo sets Default, so the field has been a no-op everywhere it was passed. Drop it rather than carry an option that does nothing.

Test plan

  • go build ./...
  • go vet ./cmd/configure/... ./cmd/auth/... ./libs/cmdio/...
  • go test ./libs/cmdio/... ./cmd/configure/... ./cmd/auth/...

This pull request and its description were written by Isaac.

AllowEdit only affects how promptui renders a non-empty Default: with
AllowEdit:true the default pre-fills the buffer; with AllowEdit:false
it appears as a placeholder that's wiped on first keystroke. No caller
in the repo sets Default, so the field has been a no-op everywhere it
was passed. Drop it rather than carry an option that does nothing.

Co-authored-by: Isaac
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Approval status: pending

/cmd/auth/ - needs approval

Files: cmd/auth/auth.go, cmd/auth/login.go
Suggested: @simonfaltum
Also eligible: @tanmay-db, @tejaskochar-db, @hectorcast-db, @mihaimitrea-db, @renaudhartert-db, @parthban-db, @Divyansh-db, @chrisst, @rauchy

/cmd/configure/ - needs approval

Files: cmd/configure/configure.go
Suggested: @simonfaltum
Also eligible: @tanmay-db, @tejaskochar-db, @hectorcast-db, @mihaimitrea-db, @renaudhartert-db, @parthban-db, @Divyansh-db, @chrisst, @rauchy

/libs/cmdio/ - needs approval

Files: libs/cmdio/prompt.go
Suggested: @simonfaltum
Also eligible: @tanmay-db, @tejaskochar-db, @hectorcast-db, @mihaimitrea-db, @renaudhartert-db, @parthban-db, @Divyansh-db, @chrisst, @rauchy

Any maintainer (@andrewnester, @anton-107, @denik, @shreyas-goenka, @simonfaltum, @renaudhartert-db) can approve all areas.
See OWNERS for ownership rules.

@pietern pietern temporarily deployed to test-trigger-is May 4, 2026 15:35 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Approval status: pending

/cmd/auth/ - needs approval

Files: cmd/auth/auth.go, cmd/auth/login.go
Suggested: @simonfaltum
Also eligible: @tanmay-db, @tejaskochar-db, @hectorcast-db, @mihaimitrea-db, @renaudhartert-db, @parthban-db, @Divyansh-db, @chrisst, @rauchy

/cmd/configure/ - needs approval

Files: cmd/configure/configure.go
Suggested: @simonfaltum
Also eligible: @tanmay-db, @tejaskochar-db, @hectorcast-db, @mihaimitrea-db, @renaudhartert-db, @parthban-db, @Divyansh-db, @chrisst, @rauchy

/libs/cmdio/ - needs approval

Files: libs/cmdio/prompt.go
Suggested: @simonfaltum
Also eligible: @tanmay-db, @tejaskochar-db, @hectorcast-db, @mihaimitrea-db, @renaudhartert-db, @parthban-db, @Divyansh-db, @chrisst, @rauchy

Any maintainer (@andrewnester, @anton-107, @denik, @shreyas-goenka, @simonfaltum, @renaudhartert-db) can approve all areas.
See OWNERS for ownership rules.

@pietern pietern temporarily deployed to test-trigger-is May 4, 2026 15:35 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant