You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Drops github.com/fatih/color as a direct dependency by migrating its ~14 call sites (bundle render, bundle run, cfgpickers, logstream, cmd/labs, experimental/aitools, experimental/ssh, python_mutator) to a small ANSI helper set.
Adds libs/cmdio/color.go with cmdio.Red(ctx, msg)-style helpers and a RenderFuncMap(ctx) for templates. The gate matches fatih/color's historical stdout-TTY decision and degrades to plain text when ctx has no cmdIO attached.
No user-visible output changes — the new helpers emit byte-identical SGR sequences.
Test plan
Manual smoke: databricks bundle validate against a bundle with errors and warnings (colored summary on TTY, uncolored when piped) and databricks current-user me -o json (colored on TTY, uncolored when piped through jq).
This pull request and its description were written by Isaac.
@simonfaltum -- recent work in libs/cmdio/, ./, experimental/aitools/lib/installer/
Any maintainer (@andrewnester, @anton-107, @denik, @shreyas-goenka, @simonfaltum, @renaudhartert-db) can approve all areas.
See OWNERS for ownership rules.
@simonfaltum -- recent work in libs/cmdio/, ./, experimental/aitools/lib/installer/
Any maintainer (@andrewnester, @anton-107, @denik, @shreyas-goenka, @simonfaltum, @renaudhartert-db) can approve all areas.
See OWNERS for ownership rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/fatih/coloras a direct dependency by migrating its ~14 call sites (bundle render, bundle run, cfgpickers, logstream, cmd/labs, experimental/aitools, experimental/ssh, python_mutator) to a small ANSI helper set.libs/cmdio/color.gowithcmdio.Red(ctx, msg)-style helpers and aRenderFuncMap(ctx)for templates. The gate matches fatih/color's historical stdout-TTY decision and degrades to plain text when ctx has no cmdIO attached.libs/cmdio/color.go.No user-visible output changes — the new helpers emit byte-identical SGR sequences.
Test plan
databricks bundle validateagainst a bundle with errors and warnings (colored summary on TTY, uncolored when piped) anddatabricks current-user me -o json(colored on TTY, uncolored when piped throughjq).This pull request and its description were written by Isaac.