Skip to content

feat(notifications): add new notifications#1076

Open
nicolaskempf57 wants to merge 8 commits into
mainfrom
feat/new-notifications
Open

feat(notifications): add new notifications#1076
nicolaskempf57 wants to merge 8 commits into
mainfrom
feat/new-notifications

Conversation

@nicolaskempf57
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@ThibaudDauce ThibaudDauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not a big fan of all this duplication between notifications. Maybe we should create a NotificationLayout component and expose title, icon, etc. to be more lean.

Comment thread components/Notifications/NewDataservice.vue Outdated
@nicolaskempf57
Copy link
Copy Markdown
Contributor Author

Still not a big fan of all this duplication between notifications. Maybe we should create a NotificationLayout component and expose title, icon, etc. to be more lean.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants