Skip to content

fix: prevent invalid data from being entered into the extensions list#67

Open
luxploit wants to merge 1 commit into
dect-e:mainfrom
luxploit:main
Open

fix: prevent invalid data from being entered into the extensions list#67
luxploit wants to merge 1 commit into
dect-e:mainfrom
luxploit:main

Conversation

@luxploit
Copy link
Copy Markdown

This should fix the problem that @a2luca was debugging at FSCK, whereby entering an emoji or a string greater then 20 characters would cause the registration to crash somewhere far down the chain (somewhere in OMM land iirc).

Also cleared up some excess line breaks :)

also cleared away some excess new lines and fixed a few indentations
@a2luca
Copy link
Copy Markdown
Contributor

a2luca commented May 12, 2026

Nice, thank you 🎉

@blackdotraven
Copy link
Copy Markdown
Member

the idea when we encountered the bug the first time was to add the filtern in the omm microservice.

The tool should be able to be a standalone sip-tool too. This means filtering in the core-service is maybe not the best option.

and we did use emojis before without problems

please do not reformat multiple lines that do not belong to the fixed bug in the same commit

Copy link
Copy Markdown
Member

@blackdotraven blackdotraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above.
Discussion needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants