Vue 3 migration: Phase 1 — core infrastructure (#1033)#1037
Merged
Conversation
Pinia stores (user/auth, system/RBAC, websocket), useWebSocket() composable, HTTP interceptor, full router with beforeEach guard, platform/utils/logger ports, API types, constants, full BVN navbar App.vue, and stub views. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
client
- Switch to BApp wrapper + unplugin-vue-components/BootstrapVueNextResolver for automatic per-component tree-shaken imports (no global plugin needed) - Add bootstrap-vue-next/dist/bootstrap-vue-next.css import in main.ts - Add data-bs-theme="dark" to BNavbar so text renders white on info background (Bootstrap 5 equivalent of Bootstrap 4's type="dark") - Add components.d.ts to tsconfig includes for GlobalComponents type augmentation - Gitignore components.d.ts (auto-generated by unplugin-vue-components on build) - Fix NotFoundView copy and centering to match Vue 2 404View exactly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These are transitive deps of @rolldown/binding-wasm32-wasi (cpu: wasm32). npm doesn't install the wasm32 binding on macOS arm64, so their lockfile entries were missing. Added as optionalDependencies to force inclusion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These are transitive deps of @rolldown/binding-wasm32-wasi (cpu: wasm32). npm skips that binding on macOS arm64 so its deps never get lockfile entries, causing npm ci to fail on Linux CI. Adding them explicitly to devDependencies forces npm to resolve and record their entries in the lockfile on all platforms. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user.ts(auth, current user, RBAC, settings),system.ts(global settings, RBAC roles, available shows, permission getters),websocket.ts(WS connection state, persistsinternalUUIDonly)useWebSocket()composable: module-level singleton replacing vue-native-websocket; handles WS lifecycle, OP routing, exponential-backoff reconnectjs/http-interceptor.ts: port of Vue 2 interceptor; callsuseUserStore()inside the fetch override (not at module scope) to respect Pinia lifecyclejs/platform/(browser.ts, electron.ts, index.ts): verbatim copies — no Vue 2 APIsjs/utils.ts,js/logger.ts,js/customValidators.ts: framework-agnostic portstypes/api/+types/index.ts+constants/: verbatim copies fromclient/src/router/index.ts: full route list with Vue Router 5/:pathMatch(.*)*catch-all + asyncbeforeEachguardApp.vue: full BVN navbar port (<script setup>,storeToRefs,useVuelidate,onMounted)NotFoundView.vue,PlaceholderView.vue,LoginView.vue,ServerSelector.vueKey design decisions
localStorageunderdigiscript_auth_token(same key as Vue 2) —authTokengetter reads localStorage directlyawait import()inside action bodies or module-level lazy accessor functions (getUserRbac()) inside getter bodieswsStore.registerSend(sendObj)called by composable on init so stores can send WS messages without circular importscurrentShowstored insystem.tsfor Phase 1; migrates tostores/show.tsin Phase 6window.confirm()for destructive actions: temporary; replaced by BVN modal in Phase 6Test plan
npm run build— no errorsnpm run typecheck— passesnpm run ci-lint— passesnpm run test:run— passes/ui-new/— BVN navbar renders, unauthenticated routes redirect to/ui-new/loginSET_UUID/WS_AUTH_SUCCESS)🤖 Generated with Claude Code