Flushed indentation for wrapped text on bullet point lists#124
Flushed indentation for wrapped text on bullet point lists#124MysterieCatDev wants to merge 14 commits into
Conversation
|
Hi! Could you please open a separate PR against main for the Fedora instructions ? Ill merge immediately I had in mind an approach but we had no time to try it out. Will try yours beforehand and see how it goes. Thank you for the time spent and efforts <3 will come back to you! |
I wasn't sure what the issue was but I figured it was just dev-jank. I was just running the program straight from the builddev src folder. In the end I figured it was unrelated to the functionality improvements so it probably wasn't a big deal.
👍 in #125
|
|
Daily driving a dev build for a couple days, but this seems to hit the same issue ive met with the proof of concept in #121 Yours is a bit smarter, initial size always works, but also breaks down faster. I had in mind to hot-fix the TextTag on zoom change, and introduce a to_indent_spacing() method for each zoom level. However did too much dev things lately so will have to wait a bit |
Ahh yeah, I didn't even test with the zoom settings. Try this update and let me know what you think, basically just attempting to remeasure any time the zoom level changes. |
|
Looks pretty good! Running a dev build for a couple days, will check where it breaks or not |
|
Okay, im back Theres a couple issues: it isnt quite there but it is approaching! |
|
This is real good Mostly trivial stuffs i can see
Id reduce a bit the spacing, |
|
I'll see what I can do, I think they're all easy fixes. I just have a lot of projects I'm juggling at the moment, and work, so it's a little difficult to get to this in a timely manner but I will definitely get to it for sure. That said, If you want to step in with a commit or two, I won't complain. :) |
|
Lots of stuff here too. I dont mind.... |
|
Oh man that's plenty of time, especially compared to how much we've done in how little time it's taken to do it. |
|
So I skipped breakfast :D I think this should fix those issues. Local testing looked okay but let me know. |
| var old_prefix = _list_item_start; | ||
| _list_item_start = value; | ||
| migrate_list_prefixes (old_prefix, value); |
There was a problem hiding this comment.
| var old_prefix = _list_item_start; | |
| _list_item_start = value; | |
| migrate_list_prefixes (old_prefix, value); | |
| migrate_list_prefixes (_list_item_start, value); | |
| _list_item_start = value; |
Id rather set the sauce to the new sauce after we migrated everything
|
|
||
| private Gtk.EventControllerKey keyboard; | ||
| public string list_item_start {get; set;} | ||
| private Gtk.TextBuffer? observed_buffer; |
There was a problem hiding this comment.
i struggle with the whole observed_buffer thing. It feels very wrong, we end up with twice the amount of text per sticky note in memory (not even counting the gtk cruft), and compare them constantly at every change
i really need to sit down and work on this
kjhbrgkdfgb breakfast first, Jorts isnt worth skipping breakfast. Please take care of yourself. i feel like we have created a monster |
|
Added thoughts, but the ability for users to set their own prefix may just not be easily maintainable with ths less weird for users, and probably easier for all this |
Yeah, people are probably more concerned with getting bulleted lists over the exact format of the bullet itself, so this is probably a good move and would definitely reduce some of the complexity. That said, feel free to branch this branch go nuts. |
What this does
This PR:
Fixes #120
Screenshots