test: fix flaky timing in test_cancel_terminated_invocation#619
Open
fgmacedo wants to merge 1 commit into
Open
test: fix flaky timing in test_cancel_terminated_invocation#619fgmacedo wants to merge 1 commit into
fgmacedo wants to merge 1 commit into
Conversation
Replace the fixed 150ms sleep with a deadline-bounded poll loop. On slower CI runners (e.g., Python 3.11 on GitHub Actions) the executor had not yet posted done.invoke.loading when the assertion ran, leaving the configuration in 'loading' instead of 'ready'. The new loop drives the processing loop in 20ms ticks until the final state is reached, with a 2s ceiling. Signed-off-by: Fernando Macedo <fgmacedo@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #619 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 5027 5027
Branches 812 812
=========================================
Hits 5027 5027
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sleep+processing_loopwith a deadline-bounded poll (20 ms ticks, 2 s ceiling) untilreadyenters the configurationContext
The CI run for the merge of
release/3.1.0intodevelopfailed onbuild (3.11):The 150 ms wasn't enough for the executor to post
done.invoke.loadingbefore the assertion. The test was added before 3.0.0 (#571), so this is a pre-existing flake, not a 3.1.0 regression.Locally the new version passed 10/10 runs.