Skip to content

Propose fix for nc/idl map#284

Open
jkuhl-uni wants to merge 1 commit into
fjosw:developfrom
jkuhl-uni:fix/oqcd_fed_idx
Open

Propose fix for nc/idl map#284
jkuhl-uni wants to merge 1 commit into
fjosw:developfrom
jkuhl-uni:fix/oqcd_fed_idx

Conversation

@jkuhl-uni
Copy link
Copy Markdown
Collaborator

This is the fix I would propose for #283.
The interplay of this change and the lines 379, 380 is a bit strange to me.
In the proposed change, those lines would only play a role, if dtr_read < diffmeas and we need diffmeas to find the configuration numbers.
This would mean that, if I were to use dtr_read = n * diffmeas, I would end up with 1/n of the statistics and, obviously, a wrong idl, in which the indices are 1/n of their actual value).

@jkuhl-uni jkuhl-uni requested a review from fjosw as a code owner May 11, 2026 16:01
@fjosw fjosw requested a review from s-kuberski May 12, 2026 08:12
@s-kuberski
Copy link
Copy Markdown
Collaborator

Hi!
Thanks for reporting the issue and for proposing a fix. I will look into both (also trying to remember if I have observed something like this in the past).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants