Update to Jai 0.2.029#656
Open
caztanj wants to merge 1 commit into
Open
Conversation
caztanj
force-pushed
the
jai_0.2.029
branch
3 times, most recently
from
2e72bac to
445a410
Compare
Collaborator
|
Looking good, but I haven't tested it so please let me know when you think it's ready to be merged 👍 |
Contributor
Author
|
I think it's ready now. I've used it a couple of days on macOS now and it also compiles and runs on both Windows and Linux now. |
obiwanus
reviewed
May 13, 2026
| td.name = sprint("Worker thread % for queue %\0", it_index, queue); | ||
|
|
||
| ts := *td.ts; | ||
| set_initial_data(ts, TEMPORARY_STORAGE_SIZE, td.ts_data.data); |
Collaborator
There was a problem hiding this comment.
Do we not need to set it manually?
Contributor
Author
There was a problem hiding this comment.
Yes, apparently i forgot to check it in.
|
|
||
| if display.base.type != Base_Display return true; | ||
|
|
||
| display.* = .{}; |
Collaborator
There was a problem hiding this comment.
Does this assignment no longer work?
Contributor
Author
There was a problem hiding this comment.
No, it gives this error message:
focus/modules/Linux_Display/linux_display.jai:46,17: Error: Struct literals cannot be used to provide values for untagged unions.
if display.base.type != Base_Display return true;
display.* = .{};
^^^
focus/modules/Linux_Display/linux_display.jai:8,12: Info: Here is the type of the expression.
}
Display :: union {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the Details union to a tagged union since struct literals can no longer be used to assign values to untagged unions.