Skip to content

PR for issue #140 - Missing Wallet Query Interface in SDK to Retrieve Created Wallet Information#160

Open
johnnynanjiang wants to merge 8 commits into
fystack:masterfrom
johnnynanjiang:issue/140-round-1
Open

PR for issue #140 - Missing Wallet Query Interface in SDK to Retrieve Created Wallet Information#160
johnnynanjiang wants to merge 8 commits into
fystack:masterfrom
johnnynanjiang:issue/140-round-1

Conversation

@johnnynanjiang
Copy link
Copy Markdown
Contributor

No description provided.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 9, 2026

@vietddude
Copy link
Copy Markdown
Collaborator

Approach is acceptable if we intentionally make CreateWallet idempotent, but this differs from issue #140’s requested query interface. Please document the new behavior and fix the e2e test so the second request must receive a new replayed result instead of reusing the first result from suite.keygenResults. Also consider hiding Badger-specific ErrKeyNotFound behind the KV abstraction.

@johnnynanjiang
Copy link
Copy Markdown
Contributor Author

#140

Thanks for commenting @vietddude cc @anhthii

Shall we clarify if we like to go for this option

Ok we can consider store the Create wallet response in badger and then later on when create wallet with the same id , it should return the stored the response instead of returning "duplicate" error
#140 (comment) ?

If so, then this PR is implemented this way.

If not, then we could discuss further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants