test(smoke): Isolate xcodebuild log capture#393
Merged
cameroncooke merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
Configure source and built smoke harness log-capture modules with a per-harness temporary log directory. This keeps smoke tests from requiring built runtime workspace state before the mocked command executor can capture xcodebuild and swift invocations. Co-Authored-By: OpenAI Codex <noreply@openai.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolate smoke-test xcodebuild log capture with a per-harness temporary log directory.
The workspace filesystem cleanup change made production log capture depend on configured runtime workspace state. That is correct for the real server, but the smoke harness mixes source-side bootstrap code with built tool modules. The source runtime singleton is configured, while the built log-capture module used by tool handlers is separate, so build-like smoke tests failed before reaching the mocked command executor.
This configures the source and built
xcodebuild-log-capturetest overrides to the same temporary directory and clears/removes it during harness cleanup. That keeps smoke tests isolated without weakening production runtime workspace requirements.Validated locally with
npm run test:smoke,npm run typecheck,npm run lint,npm run format:check, andnpm run test.