Merge reference implementation SDK changes (2026-05-05)#157
Draft
Merge reference implementation SDK changes (2026-05-05)#157
Conversation
…ack, and E2E test coverage Source changes from c063458 (Expand SDK E2E runtime coverage): - Add waitFor() after destroyForcibly() in process cleanup - Expand connect method fallback to match 'Unhandled method connect' message - Extract formatCliExitedMessage helper for consistent error formatting - Wait for stderr reader before throwing in port announcement New E2E tests ported: - EventFidelityTest: assistant.usage and session.usage_info event tests - ToolResultsTest: rejected and denied resultType handling - StreamingFidelityTest: streaming disabled on resume, reasoning effort - ToolsTest: parallel tools, availableTools/excludedTools combined - PermissionsTest: noResult kind, setApproveAll, slow handler Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
…om.xml CLI version, and update scripts/codegen @github/copilot version Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Sync Reference Implementation with new commits from Copilot SDK
Merge reference implementation SDK changes (2026-05-05)
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #157
Before the change?
destroyForcibly()without waiting for the process tree to terminateAfter the change?
destroyForcibly().waitFor()ensures process tree is fully terminated before continuingisUnsupportedConnectMethod()matches both error code-32601and"Unhandled method connect"messageformatCliExitedMessage()helper used consistently acrossCopilotClientandCliServerManagerawaitStderrReader()joins the reader thread before reading the buffer in port announcement, ensuring complete error contextPorts source changes from
c063458(Expand SDK E2E runtime coverage).Pull request checklist
mvn spotless:applyhas been run to format the codemvn clean verifypasses locallyDoes this introduce a breaking change?