Skip to content

simplify unstack to only target the active stack#74

Open
skarim wants to merge 2 commits intomainfrom
skarim/unstack-cleanup
Open

simplify unstack to only target the active stack#74
skarim wants to merge 2 commits intomainfrom
skarim/unstack-cleanup

Conversation

@skarim
Copy link
Copy Markdown
Collaborator

@skarim skarim commented May 5, 2026

The unstack command previously accepted an optional [branch] positional argument to identify which stack to target. This was confusing because it wasn't clear that a branch name identifies a stack. This PR removes that argument so the command always targets the active stack — the one containing the currently checked-out branch.

Motivation

  • Using a branch name to specify a stack is unintuitive — users don't think of stacks by branch name
  • The default behavior (unstack current branch) was already the most common usage pattern
  • A future change will add the ability to specify a stack by number, which is a clearer mental model

Copilot AI review requested due to automatic review settings May 5, 2026 03:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies gh stack unstack by removing the optional [branch] positional argument so the command always targets the active stack (the stack containing the currently checked-out branch), and updates user-facing documentation accordingly.

Changes:

  • Removed the [branch] positional argument from gh stack unstack and made the command always resolve via the current branch.
  • Updated CLI documentation (README, docs site reference, skill docs) to reflect the new invocation and behavior.
  • Updated tests by removing branch-targeting coverage and adjusting the “correct stack removed” test to rely on current-branch resolution.
Show a summary per file
File Description
skills/gh-stack/SKILL.md Updates unstack docs to remove [branch] and clarify it targets the active stack.
README.md Updates unstack docs/examples to remove [branch] and describe active-stack targeting.
docs/src/content/docs/reference/cli.md Updates reference docs for unstack usage and behavior without [branch].
cmd/unstack.go Removes positional arg handling and enforces no-args invocation.
cmd/unstack_test.go Removes tests for branch-targeting and updates remaining tests for current-branch behavior.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 5/5 changed files
  • Comments generated: 2

Comment thread cmd/unstack.go
Comment thread README.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants