Skip to content

Add Architecture Guard to community catalog#2430

Merged
mnriem merged 5 commits intogithub:mainfrom
DyanGalih:add-architecture-guard-extensions
May 5, 2026
Merged

Add Architecture Guard to community catalog#2430
mnriem merged 5 commits intogithub:mainfrom
DyanGalih:add-architecture-guard-extensions

Conversation

@DyanGalih
Copy link
Copy Markdown
Contributor

@DyanGalih DyanGalih commented May 1, 2026 •
edited
Loading

Added Architecture Guard v1.4.0 extension to the community catalog with built-in Laravel support.

Changes:

  • Added architecture-guard v1.4.0 to extensions/catalog.community.json
    • Category: process (orchestrates workflow across phases)
    • Provides 6 commands for architecture governance and drift detection
    • Includes built-in Laravel adapter (no separate extension needed)
  • Added entry to Community Extensions table in README.md
  • Updated catalog timestamps to actual submission UTC datetime (2026-05-05T07:26:00Z)

Copilot AI review requested due to automatic review settings May 1, 2026 15:11
@DyanGalih DyanGalih requested a review from mnriem as a code owner May 1, 2026 15:11
Copilot AI reviewed May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds two new community extensions—Architecture Guard and a Laravel adapter—to Spec Kit’s extension discovery surfaces (community catalog + README listing).

Changes:

  • Updated extensions/catalog.community.json with two new extension entries and refreshed the top-level updated_at timestamp.
  • Updated the Community Extensions table in README.md to include the two new extensions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
extensions/catalog.community.json Adds Architecture Guard + Laravel adapter metadata to the community extension catalog.
README.md Adds the two extensions to the Community Extensions markdown table for discoverability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread extensions/catalog.community.json
Comment thread extensions/catalog.community.json Outdated
mnriem
mnriem requested changes May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Copilot feedback. If not applicable, please explain why

@DyanGalih DyanGalih force-pushed the add-architecture-guard-extensions branch from 95ce7da to 26d7428 Compare May 1, 2026 22:24
@DyanGalih
Copy link
Copy Markdown
Contributor Author

DyanGalih commented May 1, 2026 •
edited
Loading

Thanks for the review! I've addressed the feedback:

  1. Sorting: Fixed the alphabetical sorting in the catalog (architect-preview now correctly precedes architecture-guard).
  2. Extension Dependencies: Regarding the requires.extensions field: I'm intentionally introducing this to handle extension-to-extension dependencies. For framework-specific adapters like architecture-guard-laravel, it's critical to explicitly link them to the core engine they depend on. While the CLI doesn't enforce this yet, I'm proposing this shape as a proactive way to bootstrap dependency metadata in the community catalog. Since the current CLI safely ignores unknown keys in the requires block, this addition is non-breaking but provides immediate clarity for users and maintainers.

@DyanGalih DyanGalih requested review from Copilot and mnriem May 1, 2026 22:26
Copilot AI reviewed May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread extensions/catalog.community.json Outdated
mnriem
mnriem requested changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Copilot feedback. If not applicable, please explain why

@DyanGalih DyanGalih force-pushed the add-architecture-guard-extensions branch from 26d7428 to a37f567 Compare May 4, 2026 15:35
@DyanGalih DyanGalih requested review from Copilot and mnriem May 4, 2026 15:36
Copilot AI reviewed May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mnriem mnriem requested a review from Copilot May 4, 2026 19:27
Copilot AI reviewed May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment thread README.md Outdated
Comment thread extensions/catalog.community.json
@mnriem
Copy link
Copy Markdown
Collaborator

mnriem commented May 4, 2026

Please address Copilot feedback and please refrain from making changes to other catalog entries. Is the Laravel extension adding new commands? Can you do that as a preset instead? Just wondering as it seems to indicate you are trying to layer in Laravel specific requirements?

mnriem
mnriem requested changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above

@DyanGalih DyanGalih force-pushed the add-architecture-guard-extensions branch from a37f567 to bb99bc8 Compare May 5, 2026 07:07
@DyanGalih DyanGalih changed the title Add Architecture Guard and Laravel adapter to community catalog Add Architecture Guard to community catalog May 5, 2026
@DyanGalih
feat: add Architecture Guard to community catalog
c80eeac 
- Add architecture-guard v1.4.0 extension entry to catalog
- Add entry to README community extensions table
- Includes built-in Laravel-specific governance rules
Copilot AI review requested due to automatic review settings May 5, 2026 07:17
@DyanGalih DyanGalih force-pushed the add-architecture-guard-extensions branch from bb99bc8 to c80eeac Compare May 5, 2026 07:17
Copilot AI reviewed May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread extensions/catalog.community.json
Comment thread extensions/catalog.community.json Outdated
@DyanGalih
fix: address PR feedback
d155825 
- Add 'governance' category to README legend (used by Architecture Guard)
- Update architecture-guard timestamps to 2026-05-05 (submission date)
- Align with published extension behavior (Laravel support now built-in)
Copilot AI review requested due to automatic review settings May 5, 2026 07:23
Copilot AI reviewed May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread extensions/catalog.community.json Outdated
Comment thread extensions/catalog.community.json Outdated
Comment thread README.md Outdated
DyanGalih added 2 commits May 5, 2026 07:27
@DyanGalih
chore: update Architecture Guard category to process
27d27e4 
- Changed from 'governance' to 'process' (official category)
- Aligns with schema in EXTENSION-PUBLISHING-GUIDE.md
- Removed 'governance' from category legend (not an official category)
@DyanGalih
chore: update timestamps to actual UTC datetime
7bb1151 
- Top-level updated_at: 2026-05-05T07:26:00Z
- Entry created_at/updated_at: 2026-05-05T07:26:00Z
- Replaces placeholder 00:00:00Z with actual submission time
Copilot AI review requested due to automatic review settings May 5, 2026 07:33
Copilot AI reviewed May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
@DyanGalih DyanGalih requested a review from Copilot May 5, 2026 07:39
Copilot AI reviewed May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DyanGalih DyanGalih requested a review from mnriem May 5, 2026 07:42
@mnriem mnriem requested a review from Copilot May 5, 2026 15:25
Copilot AI reviewed May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new

@mnriem mnriem merged commit 10f63c9 into github:main May 5, 2026
21 of 23 checks passed
@mnriem
Copy link
Copy Markdown
Collaborator

mnriem commented May 5, 2026

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mnriem mnriem mnriem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DyanGalih @mnriem