Open
Conversation
AkshatG6
requested review from
brnnmrls and
mdmathias
and removed request for
mdmathias
AkshatG6
changed the title
sbc-amr-main to maingandhiakshat/sbc-amr-main to main
mdmathias
approved these changes
May 6, 2026
brnnmrls
reviewed
May 6, 2026
| 73DB419628060A9A0028B8D3 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 7345AD062703D9480020AFB1 /* Assets.xcassets */; }; | ||
| F8CE667E2F86AB020044EAFF /* Claim.swift in Sources */ = {isa = PBXBuildFile; fileRef = F8CE667D2F86AAFD0044EAFF /* Claim.swift */; }; | ||
| F8CE667F2F86AB020044EAFF /* Claim.swift in Sources */ = {isa = PBXBuildFile; fileRef = F8CE667D2F86AAFD0044EAFF /* Claim.swift */; }; | ||
| F8CE66802F86B6A30044EAFF /* Claim.swift in Sources */ = {isa = PBXBuildFile; fileRef = F8CE667D2F86AAFD0044EAFF /* Claim.swift */; }; |
Member
There was a problem hiding this comment.
Does there need to be three of these?
brnnmrls
approved these changes
May 6, 2026
Member
brnnmrls
left a comment
brnnmrls
left a comment
There was a problem hiding this comment.
expiresIn changes lgtm! I left one unrelated comment though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging
gandhiakshat/sbc-amr-mainto themainbranch.gandhiakshat/sbc-amr-mainbranch includes all the changes w.r.t supporting theAMRclaim on GSI.