fix: upgrade Mockito and JaCoCo for Java 25 compatibility#1195
Open
carlossg wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Mockito 5.20.0 and JaCoCo 0.8.12 both bundle an ASM version that does not recognize Java 25 class file format (major version 69), causing IllegalArgumentException at test time. Upgrading to versions released after Java 25 GA resolves the issue. - mockito: 5.20.0 → 5.23.0 - jacoco-maven-plugin: 0.8.12 → 0.8.14
carlossg
force-pushed
the
fix/java25-asm-compatibility
branch
from
f821dae to
8574fc5
Compare
mazas-google
approved these changes
May 13, 2026
Collaborator
mazas-google
left a comment
mazas-google
left a comment
There was a problem hiding this comment.
LGTM, thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5.20.0→5.23.00.8.12→0.8.14Problem
Both Mockito and JaCoCo bundle an ASM library that does not recognize Java 25 class file format (major version 69). Running
mvn teston Java 25 fails with:This happens because Java 25 was released in September 2025, after these versions were published. ASM 9.7 (bundled in the old versions) supports up to Java 24; Java 25 requires ASM 9.8+.
Fix
Upgraded to versions released after Java 25 GA:
Test plan
mvn test -pl corepasses cleanly on Java 25mvn testpasses (1247 tests, 0 failures — the only error isLangChain4jIntegrationTestwhich requires live API credentials and was failing before this change)