fix: include app name in FileArtifactService storage paths#5619
Open
Nant361 wants to merge 1 commit intogoogle:mainfrom
Open
fix: include app name in FileArtifactService storage paths#5619Nant361 wants to merge 1 commit intogoogle:mainfrom
Nant361 wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Response from ADK Triaging Agent Hello @Nant361, thank you for your contribution! It appears that the Contributor License Agreement (CLA) check has failed. As the You can find more information and sign the CLA at https://cla.developers.google.com/. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
FileArtifactServiceacceptedapp_namein its public artifact APIs, but stored file artifacts underroot/users/{user_id}/.... This meant the file backend did not isolate artifacts by app name.Solution:
Add a validated
app_namesegment to the file storage layout:root/apps/{app_name}/users/{user_id}/....This change passes
app_namethrough the file path helpers, keeps session-scoped and user-scoped artifact behavior intact, and updates metadata path expectations.Testing Plan
Unit Tests:
Passed locally:
uv run --extra test pytest tests/unittests/artifacts/test_artifact_service.py -q71 passed in 0.92sAdded coverage:
app_name.Manual End-to-End (E2E) Tests:
N/A. This change is covered by file artifact service unit tests.
Checklist
Additional context
This keeps the file artifact backend aligned with the artifact service API boundary and the other artifact backends.