chore: version bump to 3.6.0-rc#16098
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version from 3.5.0 to 3.6.0-rc across the changelog, CMake, Bazel, and internal version headers. It also attempts to enable the GOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB macro in the Bazel build files. Feedback from the reviewer indicates that the use of cxxopts is incorrect for Bazel's cc_library rule and should be changed to copts to avoid build failures. Furthermore, enabling this macro contradicts the associated TODO comments which advise removing the definition rather than enabling it.
| hdrs = google_cloud_cpp_rest_internal_hdrs, | ||
| # TODO(#16079): Remove macro definition when GA. | ||
| # cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], | ||
| cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], |
There was a problem hiding this comment.
This change introduces two issues:
- Incorrect Attribute:
cxxoptsis not a valid attribute for the standard Bazelcc_libraryrule; it should becopts(ordefines). Un-commenting this as-is will cause a build failure. - TODO Contradiction: The TODO on line 240 says "Remove macro definition when GA". Un-commenting this line adds the definition to the build, which is the opposite of removing it. If the feature is ready for GA, this line and the TODO should likely be deleted instead of enabled.
| cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], | |
| copts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], |
| srcs = [test], | ||
| # TODO(#16079): Remove macro definition when GA. | ||
| # cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], | ||
| cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], |
There was a problem hiding this comment.
Similar to the issue on line 241, cxxopts is an invalid attribute name (should be copts) and un-commenting it contradicts the TODO to remove the definition.
| cxxopts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], | |
| copts = ["-DGOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB"], |
1 participant
No description provided.