chore(spanner): add missing commit ts logging

[sakthivelmanii]

No description provided.

[gemini-code-assist]

Code Review

This pull request enhances error reporting and logging in TransactionRunnerImpl.java when a commitTimestamp is missing by including details about precommit tokens and retry attempts. Feedback suggests addressing a missing state in the logging logic and refactoring the code to reduce redundancy and improve maintainability.

[gemini-code-assist]

The current implementation misses logging and annotations for the case where proto.hasPrecommitToken() is true but retryAttemptDueToCommitProtocolExtension is false. This is an important state to capture for debugging the commit protocol extension. Additionally, the logic can be simplified to reduce redundancy and avoid unnecessary string literal concatenation.

                    String message =
                        "Missing commitTimestamp, response has "
                            + (proto.hasPrecommitToken() ? "precommit token" : "no precommit token")
                            + (proto.hasPrecommitToken() && retryAttemptDueToCommitProtocolExtension
                                ? " and client has already attempted commit retry"
                                : "");
                    txnLogger.log(Level.FINE, message);
                    span.addAnnotation(message);
                    throw newSpannerException(
                        ErrorCode.INTERNAL,
                        message
                            + ":\n"
                            + session.getName()
                            + "\nHas precommit token: "
                            + proto.hasPrecommitToken()
                            + "\nAlready attempted commit retry: "
                            + retryAttemptDueToCommitProtocolExtension);