chore: refactor templates to reduce duplication#17006
Open
parthea wants to merge 1 commit intorepro-508597813from
Open
chore: refactor templates to reduce duplication#17006parthea wants to merge 1 commit intorepro-508597813from
parthea wants to merge 1 commit intorepro-508597813from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the UUID4 validation in generated tests by pre-compiling the regex into a module-level constant _UUID4_RE instead of using inline strings. Feedback suggests refining the Jinja2 template logic to prevent unnecessary imports and constants when no auto-populated fields exist. Additionally, the reviewer recommended using existing macros in the ads-templates to avoid hardcoding the regex pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #16944. Please review #16944 first.
This PR addresses the feedback in #16944 (comment)