fix(geminidataanalytics)!: generate and default to v1#17007
fix(geminidataanalytics)!: generate and default to v1#17007noahdietz wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request promotes the Gemini Data Analytics API client library to v1, replacing v1alpha as the default version. The update encompasses comprehensive changes across library configuration, metadata, and documentation, alongside the complete implementation of v1 services, transports, and types. Feedback from the review identifies several documentation improvements needed in datasource.py, specifically addressing an inconsistency in the BigQueryTableReferences docstring, removing internal proto path references, and fixing a truncated attribute description.
| r"""Message representing references to BigQuery tables and property | ||
| graphs. At least one of ``table_references``, | ||
| ``property_graph_references``, or ``search_scope`` must be | ||
| populated. |
There was a problem hiding this comment.
The docstring for BigQueryTableReferences states that at least one of table_references, property_graph_references, or search_scope must be populated. However, the message definition only includes table_references. Ensure the docstring accurately reflects the implementation, even if other documentation sources (like proto files) are inconsistent.
References
- Ensure docstrings reflect logic correctly, even if other documentation sources (like proto files) are inconsistent.
| Optional. Table display_name (same as label in | ||
| cloud/data_analytics/anarres/data/looker/proto/model_explore.proto), | ||
| not required, currently only Looker has this field. |
There was a problem hiding this comment.
The docstring for display_name in the Schema message contains a reference to an internal Google proto path (cloud/data_analytics/anarres/data/looker/proto/model_explore.proto). This internal detail should be removed from the public API documentation to maintain clarity and professionalism.
| Optional. Table display_name (same as label in | |
| cloud/data_analytics/anarres/data/looker/proto/model_explore.proto), | |
| not required, currently only Looker has this field. | |
| Optional. Table display_name, not required, currently only Looker has this field. |
| sources. | ||
| display_name (str): | ||
| Optional. Field display_name (same as label in | ||
| subfields (MutableSequence[google.cloud.geminidataanalytics_v1.types.Field]): |
There was a problem hiding this comment.
The docstring for the display_name attribute in the Field message is truncated and ends abruptly. It should be completed to provide full context to the user.
daniel-sanche
changed the title
daniel-sanche
added
the
do not merge
|
I added a ! to the title, since I believe this should be a breaking change. I'm going to come back and look at this soon to be sure though |
daniel-sanche
removed
the
do not merge
daniel-sanche
changed the title
|
Removed !, because this library is in previous, so we can update the default without a major update |
daniel-sanche
changed the title
2 participants
Adds
v1to existinggoogle-cloud-geminidataanalyticsclient and switchesdefault_versiontov1.Towards b/510217868