test(bigframes): Disable movie_poster, claud_model nb tests#17009
Open
TrevorBergeron wants to merge 1 commit intomainfrom
Open
test(bigframes): Disable movie_poster, claud_model nb tests#17009TrevorBergeron wants to merge 1 commit intomainfrom
TrevorBergeron wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the notebook exclusion list in packages/bigframes/noxfile.py by adding ai_movie_poster.ipynb and remote_function_vertex_claude_model.ipynb, both of which require specific BigQuery connections. The review feedback suggests standardizing the comment for the latter notebook to # Needs CONNECTION. to maintain consistency with the existing entries in the file.
| # This anywidget notebook uses deferred execution, so it won't | ||
| # produce metrics for the performance benchmark script. | ||
| "notebooks/dataframes/anywidget_mode.ipynb", | ||
| # Needs a connection |
Contributor
There was a problem hiding this comment.
For consistency with other entries in this file (e.g., lines 711-712), please use the standard # Needs CONNECTION. comment format. This also correctly references the BigQuery 'CONNECTION' resource type.
Suggested change
| # Needs a connection | |
| # Needs CONNECTION. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕