⚡ Bolt: Optimize Iconify icon data lookup#35
Conversation
- Added a `Map`-based cache to `client/src/components/base/IconifyIcon.tsx`'s `iconData` resolution logic. - Avoids multiple loop iterations, string allocations, and property lookups on every React render. - Implemented negative result caching as well to prevent re-running loop checks for missing or invalid icons. Co-authored-by: sshahriazz <34005640+sshahriazz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added a Map-based cache to
client/src/components/base/IconifyIcon.tsxfor resolving theiconDatavalues.🎯 Why: The original lookup logic ran on every single
IconifyIconrender. For prefix-less icons, this meant splitting strings and iterating through up to 11 imported icon sets (each containing thousands of icons, which while O(1) internally, still incurs overhead per set). Furthermore, negative lookups (icons not found) always iterated through every single set. Caching these results reduces this to a single O(1) Map lookup.📊 Impact: Measurably reduces main thread time spent during render, especially on pages with many prefix-less icons or missing icons. Reduces redundant splitting and iteration overheads.
🔬 Measurement: Verify via React Profiler. Rendering a large list of 100+ components with prefix-less
IconifyIconinstances will show a noticeable drop in render times, particularly for the components handling the initial icon resolutions.PR created automatically by Jules for task 4908786848533023240 started by @sshahriazz