⚡ Bolt: Optimize IconifyIcon lookup with in-memory caching#36
⚡ Bolt: Optimize IconifyIcon lookup with in-memory caching#36sshahriazz wants to merge 1 commit into
Conversation
Co-authored-by: sshahriazz <34005640+sshahriazz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added an in-memory cache ($O(N)$ lookup across 11 dictionaries to an $O(1)$ dictionary lookup after the first render of any unique icon. Should significantly reduce JS execution time during page transitions and list rendering.
iconCache) to the customIconifyIconcomponent (client/src/components/base/IconifyIcon.tsx) to store both successful and failed (null) icon lookups.🎯 Why: The component previously iterated over 11 different icon sets (
@iconify-json/...) to find prefix-less icons on every single render. Since icons are heavily used in lists, navigation, and common components, this resulted in thousands of redundantgetIconDatacalls and loops during initial renders and updates.📊 Impact: Reduces an
🔬 Measurement: Verify by placing a
console.loginside theiconSetsloop inIconifyIcon.tsxbefore and after this change. After the change, the loop will only run once per unique icon name for the entire lifecycle of the application.PR created automatically by Jules for task 3367771893545722268 started by @sshahriazz