Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-04-27 - Cache Prefixless IconifyIcon Lookups
**Learning:** Prefixless icon lookups in `IconifyIcon` invoke an `Object.entries(iconSets)` loop and multiple string parses per icon render, causing an O(N) lookup bottleneck when rendering many icons.
**Action:** Always wrap frequent, pure, synchronous lookup functions (like icon resolving) in a global memoization cache map to make them O(1), significantly reducing CPU overhead during heavy UI rendering.
27 changes: 22 additions & 5 deletions client/src/components/base/IconifyIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,35 @@ const iconSets: Record<string, IconifyJSON> = {
"mdi-light": mdiLightIcons,
};

// ⚑ Bolt: Cache icon lookups to avoid O(N) loop on every render
const iconCache = new Map<string, any>();

const iconData = (icon: string) => {
if (iconCache.has(icon)) return iconCache.get(icon);

const [prefix, name] = icon.includes(":") ? icon.split(":") : ["", icon];

let foundData = undefined;

if (prefix && iconSets[prefix]) {
const data = getIconData(iconSets[prefix], name);
if (data) return data;
foundData = getIconData(iconSets[prefix], name);
}

for (const [_, icons] of Object.entries(iconSets)) {
const data = getIconData(icons, name);
if (data) return data;
if (!foundData) {
for (const [_, icons] of Object.entries(iconSets)) {
const data = getIconData(icons, name);
if (data) {
foundData = data;
break;
}
}
}

if (foundData) {
iconCache.set(icon, foundData);
}

return foundData;
};

const IconifyIcon = ({
Expand Down