Skip to content

[VC-52277] Add cert-manager gatherers to discovery-agent #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
George-Yanev wants to merge 1 commit into from
+28 −0
Closed

[VC-52277] Add cert-manager gatherers to discovery-agent #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions deploy/charts/discovery-agent/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,31 @@ data:
resource-type:
version: v1
resource: pods
- kind: k8s-dynamic
Copy link
Copy Markdown
Author

@George-Yanev George-Yanev May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notes: I'm not sure if those should be in the default for all use cases as we need that for NGTS

Copy link
Copy Markdown
Contributor

@SgtCoDFish SgtCoDFish May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a list of gatherers which are present in the old chart but aren't in the new chart:

data-gatherers:
  # gather k8s apiserver version information
  - kind: "k8s-discovery"
    name: "k8s-discovery"
  - kind: "k8s-dynamic"
    name: "k8s/namespaces"
    config:
      resource-type:
        resource: namespaces
        version: v1
  # gather services for pod readiness probe rules
  - kind: "k8s-dynamic"
    name: "k8s/services"
    config:
      resource-type:
        resource: services
        version: v1
  - kind: "k8s-dynamic"
    name: "k8s/ingresses"
    config:
      resource-type:
        group: networking.k8s.io
        version: v1
        resource: ingresses
  - kind: "k8s-dynamic"
    name: "k8s/certificates"
    config:
      resource-type:
        group: cert-manager.io
        version: v1
        resource: certificates
  - kind: "k8s-dynamic"
    name: "k8s/certificaterequests"
    config:
      resource-type:
        group: cert-manager.io
        version: v1
        resource: certificaterequests
  - kind: "k8s-dynamic"
    name: "k8s/issuers"
    config:
      resource-type:
        group: cert-manager.io
        version: v1
        resource: issuers
  - kind: "k8s-dynamic"
    name: "k8s/clusterissuers"
    config:
      resource-type:
        group: cert-manager.io
        version: v1
        resource: clusterissuers
  - kind: "k8s-dynamic"
    name: "k8s/googlecasissuers"
    config:
      resource-type:
        group: cas-issuer.jetstack.io
        version: v1beta1
        resource: googlecasissuers
  - kind: "k8s-dynamic"
    name: "k8s/googlecasclusterissuers"
    config:
      resource-type:
        group: cas-issuer.jetstack.io
        version: v1beta1
        resource: googlecasclusterissuers
  - kind: "k8s-dynamic"
    name: "k8s/awspcaissuer"
    config:
      resource-type:
        group: awspca.cert-manager.io
        version: v1beta1
        resource: awspcaissuers
  - kind: "k8s-dynamic"
    name: "k8s/awspcaclusterissuers"
    config:
      resource-type:
        group: awspca.cert-manager.io
        version: v1beta1
        resource: awspcaclusterissuers
  - kind: "k8s-dynamic"
    name: "k8s/mutatingwebhookconfigurations"
    config:
      resource-type:
        group: admissionregistration.k8s.io
        version: v1
        resource: mutatingwebhookconfigurations
  - kind: "k8s-dynamic"
    name: "k8s/validatingwebhookconfigurations"
    config:
      resource-type:
        group: admissionregistration.k8s.io
        version: v1
        resource: validatingwebhookconfigurations
  - kind: "k8s-dynamic"
    name: "k8s/gateways"
    config:
      resource-type:
        group: networking.istio.io
        version: v1alpha3
        resource: gateways
  - kind: "k8s-dynamic"
    name: "k8s/virtualservices"
    config:
      resource-type:
        group: networking.istio.io
        version: v1alpha3
        resource: virtualservices
  - kind: "k8s-dynamic"
    name: "k8s/routes"
    config:
      resource-type:
        version: v1
        group: route.openshift.io
        resource: routes
  - kind: "k8s-dynamic"
    name: "k8s/venaficonnections"
    config:
      resource-type:
        group: jetstack.io
        version: v1alpha1
        resource: venaficonnections
  - kind: "k8s-dynamic"
    name: "k8s/venaficlusterissuers"
    config:
      resource-type:
        group: jetstack.io
        version: v1alpha1
        resource: venaficlusterissuers
  - kind: "k8s-dynamic"
    name: "k8s/venafiissuers"
    config:
      resource-type:
        group: jetstack.io
        version: v1alpha1
        resource: venafiissuers
  - kind: "k8s-dynamic"
    name: "k8s/fireflyissuers"
    config:
      resource-type:
        group: firefly.venafi.com
        version: v1
        resource: issuers
  - kind: "k8s-dynamic"
    name: "k8s/stepissuers"
    config:
      resource-type:
        group: certmanager.step.sm
        version: v1beta1
        resource: stepissuers
  - kind: "k8s-dynamic"
    name: "k8s/stepclusterissuers"
    config:
      resource-type:
        group: certmanager.step.sm
        version: v1beta1
        resource: stepclusterissuers
  - kind: "k8s-dynamic"
    name: "k8s/originissuers"
    config:
      resource-type:
        group: cert-manager.k8s.cloudflare.com
        version: v1
        resource: originissuers
  - kind: "k8s-dynamic"
    name: "k8s/clusteroriginissuers"
    config:
      resource-type:
        group: cert-manager.k8s.cloudflare.com
        version: v1
        resource: clusteroriginissuers
  - kind: "k8s-dynamic"
    name: "k8s/freeipaissuers"
    config:
      resource-type:
        group: certmanager.freeipa.org
        version: v1beta1
        resource: issuers
  - kind: "k8s-dynamic"
    name: "k8s/freeipaclusterissuers"
    config:
      resource-type:
        group: certmanager.freeipa.org
        version: v1beta1
        resource: clusterissuers
  - kind: "k8s-dynamic"
    name: "k8s/ejbcaissuers"
    config:
      resource-type:
        group: ejbca-issuer.keyfactor.com
        version: v1alpha1
        resource: issuers
  - kind: "k8s-dynamic"
    name: "k8s/ejbcaclusterissuers"
    config:
      resource-type:
        group: ejbca-issuer.keyfactor.com
        version: v1alpha1
        resource: clusterissuers

Maybe we should just copy them all?

Copy link
Copy Markdown
Contributor

@SgtCoDFish SgtCoDFish May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've copied them all in #800

name: k8s/certificates
config:
resource-type:
group: cert-manager.io
version: v1
resource: certificates
- kind: k8s-dynamic
name: k8s/certificaterequests
config:
resource-type:
group: cert-manager.io
version: v1
resource: certificaterequests
- kind: k8s-dynamic
name: k8s/issuers
config:
resource-type:
group: cert-manager.io
version: v1
resource: issuers
- kind: k8s-dynamic
name: k8s/clusterissuers
config:
resource-type:
group: cert-manager.io
version: v1
resource: clusterissuers
Loading