Added lazy operations by jkalias · Pull Request #27 · jkalias/functional_cpp

jkalias · 2026-05-03T19:50:35Z

Addresses issue #19

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6f2880c76

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8516612aaa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c35fd9cdf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jkalias · 2026-05-03T20:23:20Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c35fd9cdf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c14c7b4742

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d85e43fa70

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2331c38a8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-04T15:35:58Z

💡 Codex Review

functional_cpp/include/map.h

Line 692 in a2c0407

std::map<TKey, TValue, TCompare> materialized;

Preserve comparator state in lazy_map::get

lazy_map::get() creates std::map<TKey, TValue, TCompare> materialized; with a default-constructed comparator, so lazy pipelines lose the comparator instance captured by the source map. This breaks valid uses with stateful comparators (ordering/equivalence can change) and fails to compile when TCompare is not default-constructible, even though fcpp::map can be constructed from a std::map with such a comparator. The issue appears whenever lazy() is used on maps that rely on comparator state and then materialized via get().

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4fca415ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jkalias · 2026-05-04T16:52:57Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9d429ee0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jkalias · 2026-05-04T17:33:30Z

@codex review

chatgpt-codex-connector · 2026-05-04T17:38:19Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jkalias added 11 commits May 3, 2026 14:35

First draft of lazy operations

02416eb

Sorting lazy vectors

939ce86

Update README.md

d49d391

Added lazy zip

2de8a90

Update README.md

7dbd369

added lazy_set

c8bfa44

added missing lazy_set overload

11b3932

lazy_set set algebra added

d4abe44

added lazy map implementation

7783261

Added contents table in README

a992870

Update README.md

d6f2880

chatgpt-codex-connector Bot reviewed May 3, 2026

View reviewed changes

Comment thread include/vector.h Outdated

Comment thread include/set.h Outdated

Comment thread include/set.h Outdated

fixed header ordering

8516612

chatgpt-codex-connector Bot reviewed May 3, 2026

View reviewed changes

Comment thread include/vector.h Outdated

header cleanups

5c35fd9

chatgpt-codex-connector Bot reviewed May 3, 2026

View reviewed changes

Comment thread include/vector.h Outdated

jkalias self-assigned this May 3, 2026

chatgpt-codex-connector Bot reviewed May 3, 2026

View reviewed changes

Comment thread include/vector.h Outdated

Comment thread include/vector.h Outdated

Fixed PR comments

c14c7b4

chatgpt-codex-connector Bot reviewed May 3, 2026

View reviewed changes

Comment thread include/set.h Outdated

Comment thread include/vector.h

Fixed lazy_set and lazy_map ownership

d85e43f

chatgpt-codex-connector Bot reviewed May 4, 2026

View reviewed changes

Comment thread include/set.h Outdated

fixed release builds asserts

2331c38

chatgpt-codex-connector Bot reviewed May 4, 2026

View reviewed changes

Comment thread include/set.h Outdated

fixed set comparator and dead code

a2c0407

Fixed map comparator and removed dead code

c4fca41

chatgpt-codex-connector Bot reviewed May 4, 2026

View reviewed changes

Comment thread include/set.h

lazy set algebra operations normalization

a9d429e

chatgpt-codex-connector Bot reviewed May 4, 2026

View reviewed changes

Comment thread include/set.h Outdated

assert for release builds

59695cb

jkalias merged commit 764adeb into main May 4, 2026
12 checks passed

jkalias deleted the lazy_operations branch May 4, 2026 18:19

jkalias mentioned this pull request May 4, 2026

Improve performance with lazy operations #19

Closed

Conversation

jkalias commented May 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jkalias commented May 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented May 4, 2026

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jkalias commented May 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jkalias commented May 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant