fix(ui): fix dark text in dark mode for carrer page#7655
fix(ui): fix dark text in dark mode for carrer page#7655AyushK5ingh wants to merge 2 commits intolayer5io:masterfrom
Conversation
Signed-off-by: ayushk5ingh <ayushks1602@gmail.com>
|
Preview deployment for PR #7655 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
rishiraj38
left a comment
There was a problem hiding this comment.
Please add the reference image before and after.
|
@AyushK5ingh , I checked the page link, but I couldn’t see this issue on my side. The text looks white on the dark background and seems fine. Could you share more details or a screenshot if the issue is still happening? |
|
I doesn't reproduce like that. It occurs when u bavigate through website to that page then it make transition sort of animation to black |
|
before with after at end Screen.Recording.2026-04-24.133124.mp4after Screen.Recording.2026-04-24.132821.mp4before is not consistent somehow. but majority of time it is reproducing. |
|
@AyushK5ingh Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Description
This PR fixes #7653.
Previously, certain text elements on the Careers page remained dark when toggling dark mode, resulting in poor visibility. This PR resolves the issue by updating
src/collections/careers/Career.style.jsto use the dynamic theme color variable (whiteSevenFiveToBlackSevenFive) for paragraphs, list items, and footer text elements.Additionally, smooth cubic-bezier transitions (
0.8s cubic-bezier(0.2, 0.8, 0.2, 1)) were added to these elements to ensure a fluid visual change when the user toggles the theme.Notes for Reviewers
Signed commits