Update spark, ldk, and cdk#56
Merged
benthecarman merged 9 commits intomasterfrom May 8, 2026
Merged
Conversation
benthecarman
force-pushed
the
update-deps
branch
2 times, most recently
from
10b9140 to
18b2112
Compare
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replace deprecated actions-rs/toolchain@v1 with dtolnay/rust-toolchain@stable and the manual actions/cache@v3 setup with Swatinem/rust-cache@v2. The purpose-built Rust cache action keys correctly on Cargo.lock + rustc version (the old key only hashed Cargo.toml so cargo update wouldn't bust it), prunes the parts of target/ that don't help on restore, and keeps build-script outputs so the bitcoind/electrs binaries downloaded by corepc-node and electrsd remain cached. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
build_test_nodes was funding the LSP, mining 6 blocks, then funding the third-party node and mining another 6. The two fundings are independent — broadcast both txs first and confirm with one batch of 6 blocks. Drops one 6-block confirmation wait (~10s on this machine) per integration test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The split into 50+51 batches dates to a regtest setup pre-modern bitcoind where 101 blocks could time out the default RPC. With current bitcoind 29.0 this fits comfortably in one call. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The 1-second invoice has already expired by the time we need it expired; sleeping 5x as long doesn't add safety, just CI time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
create_lsp and create_third_party each called set_listening_addresses with the same address twice. The second call replaces the first, so the second call alone is equivalent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.