Skip to content

is_derive/is_diff for matrices#1891

Merged
affeldt-aist merged 1 commit intomath-comp:masterfrom
affeldt-aist:robot_rocq_20260122_question
May 8, 2026
Merged

is_derive/is_diff for matrices#1891
affeldt-aist merged 1 commit intomath-comp:masterfrom
affeldt-aist:robot_rocq_20260122_question

Conversation

@affeldt-aist
Copy link
Copy Markdown
Member

@affeldt-aist affeldt-aist commented Mar 9, 2026

Motivation for this change

This is a follow-up of PR #1829 .

See in particular this message in the conversion of this PR: #1829 (comment)

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.17.0 milestone Mar 9, 2026
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Mar 9, 2026
@affeldt-aist affeldt-aist changed the title Robot rocq 20260122 question is_derive/is_diff for matrices Mar 9, 2026
@affeldt-aist affeldt-aist mentioned this pull request Mar 9, 2026
2 tasks
@yosakaon yosakaon mentioned this pull request Mar 23, 2026
2 tasks
@affeldt-aist affeldt-aist force-pushed the robot_rocq_20260122_question branch from ad01614 to 85a2a77 Compare May 3, 2026 15:25
@affeldt-aist affeldt-aist marked this pull request as ready for review May 3, 2026 15:26
@affeldt-aist
Copy link
Copy Markdown
Member Author

@yosakaon @CohenCyril @holgerthies
I also spammed two of you with a review request,
but really I think this PR just needs a double-check that the statements make sense. :-/

Copy link
Copy Markdown
Collaborator

@holgerthies holgerthies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statements look reasonable to me.

@affeldt-aist affeldt-aist force-pushed the robot_rocq_20260122_question branch from 85a2a77 to b9a85cb Compare May 8, 2026 06:08
@affeldt-aist
Copy link
Copy Markdown
Member Author

Thanks for the review!

@affeldt-aist affeldt-aist merged commit af08f5e into math-comp:master May 8, 2026
47 of 50 checks passed
@affeldt-aist affeldt-aist deleted the robot_rocq_20260122_question branch May 8, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants