Add support for HitCount and HitCondition#1548
Merged
Merged
Conversation
WardenGnaw
force-pushed
the
dev/waan/hit-condition-validation
branch
2 times, most recently
from
e32937b to
f573e17
Compare
WardenGnaw
force-pushed
the
dev/waan/hit-condition-validation
branch
from
f573e17 to
e61f18d
Compare
WardenGnaw
commented
Mar 20, 2026
This PR adds in showing the Hit count for a breakpoint and for setting a HitCondition. Enables m_supportsHitConditionalBreakpoints, OpenDebugAD7 now properly builds a AD7BreakpointRequest with a hitCondition, AD7BoundBreakpoint now properly tracks hits and will prevent a break event if theres a condition set. Added CppTests and updated DebuggerTesting for associated commands. Addresses: #472
WardenGnaw
force-pushed
the
dev/waan/hit-condition-validation
branch
from
47f59f5 to
a6f0d75
Compare
Member
Author
|
@gregg-miskelly When you have the time, could you review the latest changes? |
gregg-miskelly
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in showing the Hit count for a breakpoint and for setting a HitCondition.
Enables m_supportsHitConditionalBreakpoints, OpenDebugAD7 now properly builds a AD7BreakpointRequest with a hitCondition, AD7BoundBreakpoint now properly tracks hits and will prevent a break event if theres a condition set.
Added CppTests and updated DebuggerTesting for associated commands.
Addresses: #472