Comment typos and minor cleanups in wslcsession and lxtfs#40498
Merged
benhillis merged 1 commit intoMay 11, 2026
Merged
Conversation
* WSLCContainer.cpp comment fixes:
- "Passed this point" -> "Past this point"
- "can be bind" -> "can bind"
* lxtfs.c comment fixes:
- "afer 1980" -> "after 1980"
- "Supplies a pa value" -> "Supplies a value"
* WSLCSession.cpp:
- Move the dockerd-ready log marker to a file-scope constexpr alongside
the other socket/path constants instead of redeclaring it on every
log line in OnProcessLog.
- Drop the redundant explicit template arguments from std::accumulate
in ListImages and use a typed init value (size_t{0}).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Cleanup-only PR that fixes comment typos and performs small, non-functional code cleanups in WSLCSession for readability and minor efficiency.
Changes:
- Corrected several comment typos in
WSLCContainer.cppandlxtfs.c. - Moved the dockerd-ready log marker string to file-scope
constexprinWSLCSession.cpp. - Simplified
std::accumulateusage inWSLCSession.cppand made the accumulator type explicit withsize_t{0}.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/linux/unit_tests/lxtfs.c | Comment typo fixes in test documentation blocks. |
| src/windows/wslcsession/WSLCSession.cpp | File-scope constexpr for log marker; simplified std::accumulate call. |
| src/windows/wslcsession/WSLCContainer.cpp | Comment wording fixes related to locking and port binding. |
OneBlue
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #40489. Cleanup-only changes (no functional effect) bundled together for ease of review.
Comment typos
src/windows/wslcsession/WSLCContainer.cpp:test/linux/unit_tests/lxtfs.c:WSLCSession.cpp minor cleanups
c_dockerdReadyLogLine) to a file-scopeconstexpr autoalongside the other socket/path constants, instead of redeclaring it insideOnProcessLog(called once per log line).std::accumulateinListImagesand switch the init value tosize_t{0}so the accumulator type is explicit and matches the consumer.Notes / changes from the original bundled PR
Two changes from #40489 were intentionally dropped:
IndentLinesrewrite (index loop -> iterators withstd::next) — the original index loop is at least as readable.waitForStoprename inWSLCContainerImpl::Stop— the original one-liner is already clear, the introducedisKillSignal/shouldWaitWhenKillpair adds noise without changing meaning.c_logIdchange fromstatic constexpr char[]toconstexpr autowas also dropped because it changes the variable's type fromconst char (&)[N]toconst char *rather than being purely cosmetic.